- milestone: --> Future Release
- assigned_to: nobody --> kmasaryk
- status: open --> open-accepted
Currently, BrewBlogger applies extract efficiency to all sugar sources in a recipe. This is a concept that should only apply to grains in the mash. DME, LME or pure sugars should not be subject to this calculation. I would recommend calculating "Sugars from the mash" which would have the extract efficiency applied, "Sugars in the boil" which would not have it applied (steeped grains in an extract might be included here with 0 efficiency, although that's not optimal), and finally there could be a category for sugars added during fermentation (primary or secondary) for those Belgian recipes where sugars are repeatedly added to keep the yeast working over time.
The simplest and quickest would obviously just have a flag that simple sugars ingredients (DME, LME, Cane, Corn, Lactose, Fructose, Molasses, etc.) are excluded from the efficiency multiplier.
For a quick and dirty math way of getting to the right result, make a field called Mashable with 1 for true, other pure sugars with a 0. When calculating sugar contribution of an ingredient to the recipe, it would be your current calculation but where you currently multiply by Extract Efficiency, multiply by the following:
Efficiency Factor = 1 - Flag * (1 - Extract Efficiency)
This would become 1 for processed sugars, but remain Extract Efficiency for the grains. Might be a kludge, but a workable short term fix before adding enhanced functionality down the line.