Menu ▾ ▴

#93 Error in efficiency calculation

2.3.2 BETA
open
nobody
Data Display (31)
5
2011-08-10
2011-08-10
Anonymous
No

The efficiency calculation for the brew blog detail page will be incorrect if the recipe has three or more grains in it. It is due to a typo in the sugar PPG fetch.

I tracked down a bug in includes/efficiency.inc.php, line 13:
$row_sugarPPG3 = mysql_fetch_assoc($sugarPPG1);

That should be changed to:
$row_sugarPPG3 = mysql_fetch_assoc($sugarPPG3);

Discussion

  • Kevin Masaryk

    Kevin Masaryk - 2011-08-10

    Thanks for the report. Actually, the whole efficiency and PPG system has already been rewritten so the next version will not have this issue. Not to say it won't have others, though!

    The fix you posted should help people with the current version.

    This ticket can be closed.

     

  • Geoff Humphrey

    Geoff Humphrey - 2012-03-22

    Nice catch. Thanks!