1) Your changes assume you will only be building on OSX, the sources still need to build for other targets. I suggest you copy makefile to makefile.osx and make the chenges there, then make the changes to the other files conditionally compilable.
2) The files from Darrell Walisser don't have any licence information, I can't include them if I don't know that I'm allowed to legally distribute them. Brandy is a GPLv2 program, see the COPYING file and the header in each source file.
Colin
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2013-06-22
status: open --> pending
assigned_to: Colin Tuckley
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sean,
I can't accept this patch for two reasons:
1) Your changes assume you will only be building on OSX, the sources still need to build for other targets. I suggest you copy makefile to makefile.osx and make the chenges there, then make the changes to the other files conditionally compilable.
2) The files from Darrell Walisser don't have any licence information, I can't include them if I don't know that I'm allowed to legally distribute them. Brandy is a GPLv2 program, see the COPYING file and the header in each source file.
Colin