[BProc] Re: bproc-4.0.0pre5 - not that qstr

[<er...@he...>]

On Wed, Jul 07, 2004 at 04:49:19PM -0600, Michal Jaegermann wrote:
> 
> I believe that I run into another typo in bproc-4.0.0pre5.  In dcache.h
> there is the following definition:
> 
> struct qstr {
>         unsigned int hash;
>         const unsigned char *name;
>         unsigned int len;
> };
> 
> Initializations in kernel/bpfs.c attempt to assign a pointer to a string
> to 'hash'.  Therefore it seems to me that the following was really intended:

Yep.  They moved those fields around at some point between 2.4 and
here.  I changed it so it's a stack variable and made the definitions
look like this.  This should avoid this issue if they decide to move
the fields around again.  Thanks for pointing that out.

    struct qstr name = { .name = name_,
                         .len  = strlen(name_),
                         .hash = 0};    /* screw the hash... */


- Erik