From: <ha...@no...> - 2002-10-30 16:17:46
|
Is it hard to reconcile bproc with highmem ? I found J.A. Magallon's patch collection 2.4.20-pre10-jam1 and wanted to use it on Abit-IT7-MAX2 based cluster (patches contain both HPT374 support and bproc kernel patch; this made me happy). I did few replacements in bproc (using J.A.M.'s hints): nice = current->nice -----> nice = task_nice(current) current->nice = nice -----> set_user_nice(current,nice) DEF_NICE -----> (0) and bproc-3.2.2 compiled OK. However depmod complains about unresolved symbol kmap_pagetable in vmadump.o. This is caused by new highmem (1G and more memory support) and there already was lot of buzz regarding many drivers broken by highmem. There seem to be quick 'fixes' like replacing #include <asm/pgtable.h> with #include <linux/highmem.h>, but there is more to it: Andrea Arcangeli May 4 2002: > You should #include <linux/highmem.h> in those drivers .c files, then it > will compile, but that's not the right fix, you'd need to add the > pte_kunmap too or it would deadlock with highmem. The right fix is to > convert those drivers to vmalloc_to_page, then they will work flawlessy. > Alan actually has a patch in his -ac that converted most usb and other > drivers to vmalloc_to_page, I will merge it plus I will convert those > below drivers if they're not just covered by Alan's patch. Alan could > you push it to Marcelo? So, my question is - what does this meen for bproc? Adding <linux/highmem.h> somewhere, (complicated?) conversion to vmalloc_to_page or something more? 1G or more memory is certainly reasonable on clusters these days, what should be done to have bproc working with these? Or did I miss something and bproc can work with 1Gup without highmem? Best Regards Vaclav |