Re: [BProc] ps oops on 3.2.0

[<er...@he...>]

On Fri, Oct 18, 2002 at 10:46:57AM -0400, Nicholas Henke wrote:
> On Fri, 18 Oct 2002 10:25:27 -0400
> er...@he... wrote:
> 
> > On Wed, Oct 16, 2002 at 04:06:26PM -0400, Nicholas Henke wrote:
> > > 
> > > I can cause a node to oops everytime with the attached script. I am
> > > running bproc-3.2.0 on 2.4.18, with the procfs locking patch. 
> > > Here is the oops fed through ksymoops after rebooting.
> > 
> > In general, I'd say I don't worry about co-existing nicely other
> > patches.  It's just too much trouble for me.  If you point me at the
> > other patch you're using I might be able to see what the problem is
> > pretty quickly though.  More likely, the locking is all moved around
> > in procfs and the BProc hooks need to be modified accordingly.  The
> > BProc hooks into procfs are pretty messy since things need to be done
> > atomically and there's a bunch of lock grabbing/releasing code already
> > in there.
> > 
> Sorry for the confustion. -- it is the patch that you sent me for the
> last oops I sent, where we moved the bproc_hook_imv call inside the lock
> in fs/proc/array.c ( I think that is the file.)

Oh, I see.  I should extend that policy to my own patches :)

Seriously though, I took your script and reproduced it so I'm looking
at it now.

- Erik