Menu

#21 view.php: missing tree nodes; incorrect sorting

open
5
2003-10-22
2003-10-22
Anonymous
No

I just upgraded my server to 0.2.0 minimal.
When I view my bookmarks in IE or with the 1.4 client I
see:

19 top-level folders (with sub-folders)
8 top-level bookmarks

When I view my bookmarks through view.php I see:

The first 9 top-level folders
The 8 top-level bookmarks
The 8 top-level bookmarks repeated

When I expand the last top-level folder some (but not
all) of the missing top-level folders appear below and
the 8 top-level bookmarks are still listed twice (1 though
8 followed again by 1 through 8).

I expect this may be hard to debug without actually
seeing it. Contact me if I can help sort it out.

tr45h126@koett.ca

Discussion

  • Greg LaBrec

    Greg LaBrec - 2003-10-22

    Logged In: YES
    user_id=650625

    I have the same problem, but there is more. In a case where
    the following is the makeup:

    -- Artwork (dir)
    -- Apple (dir)
    -- Books (dir)
    -- Catalogs (dir)
    Asteroids (root of "Apple")
    Axe Handles (root of "Apple")
    Buttons (root of "Apple")
    Operating Systems (root of "Apple")
    -- Business (dir)
    Antics (root)
    Cats (root)
    Putters (root)

    view.php displays the following tree:

    -- Artwork (dir)
    -- Apple (dir)
    Asteroids (root of "Apple")
    Axe Handles (root of "Apple")
    -- Books (dir)
    -- Catalogs (dir)
    -- Business (dir)
    Antics (root)
    Cats (root)
    Putters (root)
    Antics (root)
    Cats (root)
    Putters (root)

    Note that in the "Apple" directory the root entries are initially
    sorted with the directory names. Since the root
    entries "Asteroids" and "Axe Handles" are alphabetically
    before "Books", they are displayed first. Then, as soon as the
    first directory appears in the sort, the remainder of the root
    entries ("Buttons" and "Operating Systems") are not displayed
    at all.

     
  • Morbus Iff

    Morbus Iff - 2003-10-22

    Logged In: YES
    user_id=69804

    What version of IE are you using? Glabrec? Original
    reporter? I'll probably end up replacing the javascript in
    view.php with something else entirely - I've just discovered
    it doesn't work in Mozilla or Safari. Perhaps something like
    Joust? http://www.ivanpeters.com/

     
  • Morbus Iff

    Morbus Iff - 2003-10-22
    • assigned_to: nobody --> morbus
     
  • Morbus Iff

    Morbus Iff - 2003-10-22
    • summary: Glitch in view.php --> view.php: missing tree nodes; incorrect sorting
     
  • Morbus Iff

    Morbus Iff - 2003-10-22

    Logged In: YES
    user_id=69804

    Or http://www.treeview.net/.

     
  • Morbus Iff

    Morbus Iff - 2003-10-23

    Logged In: YES
    user_id=69804

    Just discovered: http://phplayersmenu.sourceforge.net/.
    Looks yummy. Open-source too.

     
  • Nobody/Anonymous

    Logged In: NO

    Well that at the end twice the same bookmarks are displayed
    is because of there is twice the same code in view.php.
    At the end you see:

    echo "</div>\r\n";

    if ($url_idx > 0){
    for ($idx = 0; $idx < $url_idx; $idx++)
    echo $myurl[$idx];
    }
    }
    for ($idx = 0; $idx < $items; $idx++)
    echo "</div>\r\n";

    echo "</div>\r\n";

    if ($url_idx > 0){
    for ($idx = 0; $idx < $url_idx; $idx++)
    echo $myurl[$idx];
    }

    Just remove the second same part and you are done.

    I can not find the other bug yet. (when using subs, not all
    bookmarks are displayed until you collapse).

    Johan

     

Log in to post a comment.