#23 Game crashes during a match when start button is pressed

[Bernd A.]

The error was reported in this tracker item by Adam: https://sourceforge.net/tracker/?func=detail&aid=2907122&group_id=81520&atid=563213.

How to reproduce:
- Delete config.xml
- Attach two joysticks
- Start game
- Select joystick 1 for player 1 and joystick 2 for player 2
- During a match, press the start button

Assertion failed:
File: cinput.h, Line: 131
Expression: PlayerInput < GetPlayerInputCount()

[Bernd A.]

Call stack is:
_wassert(...)
CInput::GetPlayerInput(int PlayerInput=72), Line 131
CMatch::ManagePauseMessage(), Line 672
CMatch::Update(), Line 1033
CGame::OnWindowActive(), Line 948
CWindow::MessagePump(), Line 285
...

CMatch.cpp, Line 672: Call is m_pInput->GetPlayerInput(72).Update();
m_pOptions->GetPlayerInput(i=6) returns 72.

That's a bit confusing. I think line 671 should be "do i = 0 to maxplayer", because m_pOptions->GetPlayerInput(...) has the player id (0..maxplayer-1) as parameter.

[Bernd A.]

Committed r652. Verified! Now the game crashes with assert in COptions::GetPlayerInput( int Player = 5), Line 199.

http://bombermaaan.svn.sourceforge.net/viewvc/bombermaaan?view=rev&revision=652

[Bernd A.]

Fixed:
http://bombermaaan.svn.sourceforge.net/viewvc/bombermaaan?view=rev&revision=653

Waiting for confirmation by Adam.

[Bernd A.]

Rev. 655e released.

https://sourceforge.net/projects/bombermaaan/files/2%20-%20Bombermaaan%20Experimental/Rev.%20655/Bombermaaan_1.4.0.655e_20100117_win32.zip/download

[Adam Jimenez]

i used Bombermaaan_xbox.exe.

can confirm it no longer crashes and start button triggers the pause screen.