Re: [Bobs-devel] restore_ssh - patch

[Joe Z. <jz...@co...>]

Jochen Metzger wrote:

>Hi Joe,
>
>well I had a look through the restore_rsync_ssh patch, and I had some
>thoughts I wanted to share with you.
>(Actually I did not get it really running)
>
>==
>The method itself and the main implementation is great
>==
>
>But.
>1. In this patch this restore method only works in conjunction with the
>backup method "rsync_ssh"
>
>2. It is not real rsync_ssh, but only uses the data and uses sftp
>itself.
>
>
>So there a 2 things I do think about.
>
>1 -> Might be misleading, because you can choose it as restore method.
>     also when you choose something else as 
>   
>2 -> It might be better, when it has its own data and will be pronounced
>     sftp as well (rather than rsync_ssh)
>
>Unfortunately I do not have the time at present to give it the right 
>go. 
>The question is whether to launch it this way in the release or not.
>
>The way it is will in my opinion lead to a lot misunderstanding and
>that would be no good for the image of this masterpiece of software.
>
>Cheers
>
>Jochen 
>
>   
>
Are we talking about Rene's rsync_restore.patch he posted 12-29-2003? 
That was a pretty large patch. I need to take a long look at it and try 
it out before I can comment on it.

Joe