[Bobs-devel] [Fwd: [ bobs-Patches-769206 ] minor bugfix in admin password handling]

[Joe Z. <jz...@co...>]

I just noticed this patch submission from July. I tested it and will 
move it up to cvs soon.

Joe Zacky

-------- Original Message --------
Subject: 	[ bobs-Patches-769206 ] minor bugfix in admin password handling
Date: 	Sat, 03 Jan 2004 21:21:57 -0800
From: 	SourceForge.net <no...@so...>
To: 	no...@so...



Patches item #769206, was opened at 2003-07-10 08:20
Message generated for change (Comment added) made by jzacky
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=474371&aid=769206&group_id=54656

Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Joe Zacky (jzacky)
Summary: minor bugfix in admin password handling

Initial Comment:
There is a very small bug in the way passwords
are handled when accessing admin.php that
prevents successful logins.  It is found on line
24 of class_admin.php:

$this->admin_pwd = rtrim(fgets($fp));               
// Store pwd in class data

This line should read:

$this->admin_pwd = rtrim(fgets($fp,filesize
($pwdfile)));               // Store pwd in class data

as the fgets call requires a file length to
successfully read the data from the password
file.

I have tested this change on the install here,
if you have need of more information please don't
hesitate to drop me a line at my address included
below.

Thank you for this project, it looks very promising!

M. Jackson
or...@to...

----------------------------------------------------------------------

>Comment By: Joe Zacky (jzacky)
Date: 2004-01-03 20:21

Message:
Logged In: YES 
user_id=101354

Since php version 4.2.0 the length parameter to fgets is
optional. I included this patch to make it compatible with
prior versions of php.

Thanks to M. Jackson.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=474371&aid=769206&group_id=54656