Re: [Bobs-devel] rsync over ssh -> ready

[Jochen M. <j.m...@om...>]

Hi Rene,

nice to hear from you. I lived in Denmark as well for a 
couple of years, when I was a boy of five.


> > The differences are:
> > 1. rsync over ssh does not use sharenames (which were defined in
> > rsyncd.conf), you can just use the absolute paths (e.g. /path/to/dir)
> > 2. You need a username which you use for connection
> >    (Of course one could use the login name, but I didn't want to 
> >     use that, because it could be different in the "Internet Servers"
> >     case. If a user later on should have the ability to restore things
> >     he should have restricted rights, but a rsync user should probably
> >     have more rights to set ownerships etc.
> > 
> 
> Does this include the ssh key you described earlier? 
> 

I am not sure, what you exactly mean.
I have implemented it with the public/private key feature, not using
a password at all, cause this is more safe.

But, at present, the private key is not done automagically or something.
You have to do it by hand, as described in the earlier mail.
But it works o.k.

The rsync method you used before was assuming a non authorized access,
so you did not need a username / password at all.

> 
> > It is not really secure, because the server just does not turn up in the
> > select (under http://bobsdomain/bobs/) that all. Of course you could log
> > in by setting the correct vars in the request.
> > 
> I would prefer a check against the "none" method to determine if a login
> succeeds. Just implementing this without a proper check is bad. 
> 
O.K. not a prob. You are right, that is the most proper method. I can do
it with just some small changings in the class_restore.php class , I
assume.


> Its a time off for most people. I'll be happy to help you get your
> changes included in bobs. Probably with a few changes to your work and
> some to the restore code I made.

Well that would be great. I am glad to get some hints. The problem was, 
I had to finish it, because I must switch back to some other project on
Monday, so I had to get it finished.

> 
> > So here is my version. As Joe adviced, I checked out an cvs version and
> > made the changings (and testet them several times - they work / I put
> > them in the sources and made an installation (configure and make
> > install))
> > 
> > The I made the diffs. I tried to change as little as possible. 
> > 
> 
> Please make unified diffs in the future. 

Can you give me a hint? What do you mean? I made the diffs on the
commandline with 

cvs diff

That was all.


> I find those much easier to
> read and understand.  
is there a different way?


> But still, great work!
Thanks a lot. I love the way you did that projekt. There is a lot
brainwork within this architecture. 

> 
> > I hope that you like it. I am reading that list. So if some question are
> > coming up, I am ready to answer them
> 
> 
> I'll have a closer look now. I just wanted to say Hi! and welcome to the
> bobs team :)

Fine. ;o)
> 
> If you want cvs commit rights please let me know.
> 
Sure. But it is up to you. I cannot promise, that I can do many
changings and other stuff, because I have to keep my business running.
Of course commit rights would be great.

I am used to work with CVS and of course I will ask before commiting
something.


> Cheers
> Rene
> 
Cheers

Jochen Metzger

Hope you can get through it.