|
From: Jochen M. <ml...@om...> - 2003-12-28 13:39:37
|
Hi,
who did the concept for the gui?
Joe or Rene?
What I think about, is if it is possible to change the "list" item
in config.
The advantage would be, that one could seperate option and value,
which would be better if a option should be longer.
I am running into problems, creating another backup method in the
options.
At present:
<option value="rsync">rsync</option>
<option value="rsync_ssh">rsync_ssh</option>
Could be:
<option value="rsync">rsync (using daemon)</option>
<option value="rsync_ssh">rsync (using ssh)</option>
Only two changings would be necessary for this:
1. definition in config.php.in
now:
$server_defs["backup_method"]["list"]["0"] = "rsync";
then:
$server_defs["backup_method"]["list"]["rsync"] = "rsync (using
daemon)";
2. little changing in "html_list":
gui.pinc
now:
foreach ($options as $option){
$html .= "<option value=\"$option\"";
if ($value == $option) {
$html .= " selected";
}
$html .= ">$option\n";
}
then:
foreach ($options as $index => $option){
$html .= "<option value=\"$index\"";
if ($value == $index) {
$html .= " selected";
}
$html .= ">$option\n";
}
Advantages:
o Option could be more descriptive and independent from value
o Better support for probably multilanguage - support
Disadvantage:
o config.php.in not downwards compatible to 0.6.0
Looking forward to your feedback
|