Re: [bme-develop] Final BeMSN Release Progress

[D. G. <A00...@it...>]

Hello ...

> Hi guys,
> 
> I've tested my hotmail code and it works! it generates a html file 
> that can 
> sign in to hotmail! But we have some problems in the program 
> structure! 
> first thing is the password! we need it to log in to hotmail but it's 
> stored 
> nowhere!
Good thing it works, that is great. You are right, the password is not 
being stored anywhere, it is only stored temporally in 
	char * MsnNSHandler::pass  (see MsnNSHandler::initMsnSession).
but it is destroyed after the user signs in (see 
MsnNSHandler::handleUSR).
I like the idea of a User class derived from Contact where we can hold 
this information. Common::yo will be an object of this type (yo means 
I, the pronoun, in spanish).

> 
> Secondly we get a bunch of URL information from the hotmail server, 
> see 
> http://www.hypothetic.org/docs/msn/notification/miscellaneous.php, I 
> need 
> some of those....now they are hardcoded into the program....so where 
> do we 
> store them?
How about using the MsnProtocol class which is not being used right 
now.

> 
> Thirdly, right now I can only open hotmail messages if I get a 
> initial mail 
> message...but that's send only when you've unread mails....so we 
> should 
> figure out how to login without getting that message!
What is the reason for this? Is it the id field? If so we can also get 
it in reply to a URL INBOX command. That would be something we'll need 
to add to MsnNSHandler so it can handle this type of commands and send 
BMessage reply with the value the to who asked for it.

> 
> Fourthly, the code is a real mess now! I don't like the place where 
> the mail 
> code is stored(and especially the information): mailview contains 
> mail info, 
> and the mail handling code is placed in BmeApp...I don't like this! 
> we 
> should make it more flexible....
I agree with you. We should move the code somewhere else. The 
MsnProtocol seems like a good place for it if you don't want to mix 
protocol code with view/app code.

> 
> because we have a lot of protocol information and don't know where to 
> store 
> it I suggest making a class for it that we can query....Protocol or 
> smth....or does anyone have a better idea! I think I will also change 
> the 
> profile info to a map structure....but leave it some time as it 
> is!(it works 
> now)
> 
> I really like to get started on changing the contact info classes as 
> this is 
> also needed for the hotmail integration(password)....I suggest making 
> four 
> new classes...
> -two data classes: Contact and User(derives from contact,stores the 
> password), these classes make it possible to cache contacts and 
> users!
> -a ContactItem class, this is the list item that draws the contacts
> -a ListProducer class or smth that takes the Contact classes and 
> turns them 
> into corresponding ContactItem classes and puts them in a 
> BOutlineListView(groups included)
> 
> what do you think about all of this?
Just keep in mind that there are places where the program needs to find 
a particular Contact object (MsnBuddy as of now). This happens by 
calling Common::getMsnBuddy, and this function works by sending a 
BMessage to the list that holds all the Contact objects 
(ContactListView as of now), which replys with a pointer to the object 
if it finds it. If we separate the Contact info from the 
ContactListItem we need a looper to hold the Contact list (maybe 
MsnNSHandler), so it can respond to Common::getMsnBuddy. 

Other than that I think it is a good idea to separate the views/app 
code from the protocol specific code. 
> 
> regards,
> 
> Tim
> 

Regards,
Daniel