Thread: RE: [bme-develop] Code imported into CVS
Status: Planning
Brought to you by:
sirmik
|
From: Sir M. <obe...@ho...> - 2004-03-23 11:19:42
|
Hi Daniel, I have some problems logging in, I do this: ssh -l sirmik cvs.sourceforge.net and this is what it says: Host key not found from the list of known hosts. Are you sure you want to continue connecting (yes/no)? if I choose yes or no I get the same message again. Do you know what I'm doing wrong. Btw, if I have the code from cvs I will make a doxygen file for it. Then we maybe should also make a directory for the docs generated by doxygen, regards, Tim _________________________________________________________________ MSN Search, for accurate results! http://search.msn.nl |
|
From: Sir M. <obe...@ho...> - 2004-03-23 12:17:41
|
Hi, >You have to type "yes" in full - it should then prompt you for a >password. > Ok done this...but when I enter my password(the same as for the admin tool on sf, that works), the program responds with "Permission denied"....any ideas? regards, Tim _________________________________________________________________ MSN Search, for accurate results! http://search.msn.nl |
|
From: Simon T. <sim...@ga...> - 2004-03-23 14:45:27
|
> Hi, > > >You have to type "yes" in full - it should then prompt you for a > >password. > > > Ok done this...but when I enter my password(the same as for the admin > tool > on sf, that works), the program responds with "Permission > denied"....any > ideas? It worked fine for me. Check case sensitivity and the fact that you've got your username correct too? The checkout didn't complete for me though (well it appears to have got all the files, but it had to be killed at the end). Thanks for importing the sources anyway Daniel. Simon |
|
From: Daniel G. <al7...@ma...> - 2004-03-24 05:01:10
|
Hola! > > >You have to type "yes" in full - it should then prompt you for a > > >password. > > > > > Ok done this...but when I enter my password(the same as for the > > admin > > tool > > on sf, that works), the program responds with "Permission > > denied"....any > > ideas? > > It worked fine for me. > > Check case sensitivity and the fact that you've got your username > correct too? > I had similar problems the first time. I had to change my sf password on the souceforge website, after that I could connect through the ssh, and after that to the cvs repository. > > The checkout didn't complete for me though (well it appears to have > got > all the files, but it had to be killed at the end). Thanks for > importing the sources anyway Daniel. > Same problem for me. On all cvs commands it hangs at the end, and have to kill it. But seems to get the job done. Has anyone tried from windows or other OS? > > Simon > Daniel |
|
From: Sir M. <obe...@ho...> - 2004-03-24 19:40:21
|
hello, I tried to upload some of the files I modified to cvs but it didn't seem to work...I updated Daniel's code with the changes I made earlier...time is in front of the message now, font effects work(but not entirely) and I changed insertIm in the MsnChatter class to insertIM(BMessage *msg)...Simon you might have a look at this code when starting on the new chat-window code...I also included a line of code that changes the \r\n windows enters to \n...because often I do get some blocks in my received messages, representing, I think, the \r part....Also I would recommend not making entirely new UI classes but using the old ones...in that way we can work together on the UI code, otherwise we would end up having to wait for each other... Oh...can someone check if my code is in cvs...I tried the sf cvs page, but only Daniel showed up as the one who commited code...oh one kind request...since my compiler here gives out warnings when a file is not ended in a read line...could you just place an enter at then end of each file when coding? that way probably only the warnings I truely need turn up regards, Tim > > The checkout didn't complete for me though (well it appears to have > > got > > all the files, but it had to be killed at the end). Thanks for > > importing the sources anyway Daniel. > > >Same problem for me. On all cvs commands it hangs at the end, and have >to kill it. But seems to get the job done. >Has anyone tried from windows or other OS? _________________________________________________________________ MSN Search, for accurate results! http://search.msn.nl |
|
From: Daniel G. <al7...@ma...> - 2004-03-25 23:43:15
|
Hi there. > I tried to upload some of the files I modified to cvs but it didn't > seem to > work...I updated Daniel's code with the changes I made earlier...time > is in > front of the message now, font effects work(but not entirely) and I > changed > insertIm in the MsnChatter class to insertIM(BMessage *msg)... > Oh...can someone check if my code is in cvs...I tried the sf cvs > page, but > only Daniel showed up as the one who commited code...oh one kind > request...since my compiler here gives out warnings when a file is > not ended > in a read line...could you just place an enter at then end of each > file when > coding? that way probably only the warnings I truely need turn up > My compiler has the same problem, even with Be's headers. Did you commited your changes to the cvs? I am not seeing your changes on the code. To see if the status of the repository I am using the following command cvs -d:ext:the...@cv...:/cvsroot/bme status * This compares the code on your hard drive to the one on the repository. All the files appear as up-to-date, so your changes have not been commited. Try cvs -d:ext:the...@cv...:/cvsroot/bme commit -m "Message log" file1 file2 Update will download the latest version on sourceforge to your hard drive. Daniel |
|
From: Sir M. <obe...@ho...> - 2004-03-26 10:50:40
|
Hi, >My compiler has the same problem, even with Be's headers. So we have to remember that we include a newline after each files...we can't change the Be headers, so we leave them as is....but it there should be a lot less warnings if we do it in our own files! >Did you commited your changes to the cvs? I am not seeing your changes >on the code. >To see if the status of the repository I am using the following command > cvs -d:ext:the...@cv...:/cvsroot/bme status * >This compares the code on your hard drive to the one on the repository. >All the files appear as up-to-date, so your changes have not been >commited. Try > cvs -d:ext:the...@cv...:/cvsroot/bme commit -m >"Message log" file1 file2 >Update will download the latest version on sourceforge to your hard >drive. If I do this: cvs -d:ext:si...@cv...:/cvsroot/bme commit -m I get something like this: CVS: ---------------------------------------------------------------------- CVS: Enter Log. Lines beginning with `CVS:' are removed automatically CVS: CVS: Committing in . CVS: CVS: Modified Files: CVS: Bme.proj src/Exceptions.h src/MsnApp.cpp CVS: src/MsnProtocol/NetworkHandlers/MsnSBHandler.cpp CVS: src/UserInterface/MsnChatter.cpp CVS: src/UserInterface/MsnChatter.h CVS: src/UserInterface/MsnLoginWindow.h CVS: src/UserInterface/MsnNoticeWindow.h CVS: src/UserInterface/MsnPreferencesWindow.h CVS: ---------------------------------------------------------------------- and then the system hangs...nothing gets updated...I did update the MsnSBHandler.cpp and MsnChatter.cpp/.h files...the rest will be probably be added newlines... weird, any idea what's wrong? regards, Tim _________________________________________________________________ Play online games with your friends with MSN Messenger http://messenger.msn.nl/ |
|
From: Hector D. G. <al7...@ma...> - 2004-03-26 14:45:19
|
Hello, -- Mensaje Original -- >If I do this: > >cvs -d:ext:si...@cv...:/cvsroot/bme commit -m > >I get something like this: > >CVS: -------------------------------------------------------------------= --- >CVS: Enter Log. Lines beginning with `CVS:' are removed automatically >CVS: >CVS: Committing in . >CVS: >CVS: Modified Files: >CVS: Bme.proj src/Exceptions.h src/MsnApp.cpp >CVS: src/MsnProtocol/NetworkHandlers/MsnSBHandler.cpp >CVS: src/UserInterface/MsnChatter.cpp >CVS: src/UserInterface/MsnChatter.h >CVS: src/UserInterface/MsnLoginWindow.h >CVS: src/UserInterface/MsnNoticeWindow.h >CVS: src/UserInterface/MsnPreferencesWindow.h >CVS: -------------------------------------------------------------------= --- > When you do a commit without a message, you cvs will go into vi (the text= editor) mode, so you can enter the message into the log. There is a messa= ge on the log for every commit. Do you know who to use vi? It a command base= editor, type "a" to append text, "i" to insert, ":wq" to save and close the log. Regards, Daniel |
|
From: Sir M. <obe...@ho...> - 2004-03-26 16:20:58
|
Hi, >When you do a commit without a message, you cvs will go into vi (the text >editor) mode, so you can enter the message into the log. There is a message >on the log for every commit. Do you know who to use vi? It a command base >editor, type "a" to append text, "i" to insert, ":wq" to save and close >the log. > what kind of message do you mean? pff I think I will have to read the cvs manual :S....I don't know vi, and rather keep it that way...I heard it's terrible ;) regards, Tim _________________________________________________________________ Play online games with your friends with MSN Messenger http://messenger.msn.nl/ |
|
From: Sir M. <obe...@ho...> - 2004-03-26 17:58:50
|
Hey daniel, Simon figured it out what I was doing wrong...files are in cvs now, regards, Tim _________________________________________________________________ Hotmail en Messenger on the move http://www.msn.nl/communicatie/smsdiensten/hotmailsmsv2/ |
|
From: Daniel G. <al7...@ma...> - 2004-03-27 14:56:17
|
Hello. I found a few problem with some of the changes.
The problem lays in that the MSN protocol uses the charset=3DUTF8 and so=20
does BeOS for all the GUI text displaying classes. The problem is that=20
BString cannot handle UTF8. So when you get the message body like this:
BString im;
message->FindString("body",&im);
you get some problems for most of other non ascii characters, for=20
example =E1,=E9,=ED,=F3,=FA, =F1 (If you don't see this character change =
the=20
encoding of the e-mail to Latin-1). I use these chars a lot since most=20
of my conversations are in spanish. I think the best way to handle=20
messages is to use char pointers instead of BStrings, to avoid any=20
problems with character encodings.=20
On a separate note, some suggetions for changes
Maybe move the "\r\n" replacing code to the MsnSBHandler to make the=20
MsnChatter easier, clearer more straight forward, doing all the hard=20
work in the Protocol classes.
Change the color in messages from this
rgb_color rgb =3D rgb_color();
msg.AddInt8("red",rgb.red);
msg.AddInt8("green",rgb.green);
msg.AddInt8("blue",rgb.blue);
into this:
rgb_color rgb =3D rgb_color();
msg.AddData("color",B_RGB_COLOR_TYPE,(const void*)&
rgb,sizeof(rgb));
...
const rgb_color *rgb; ssize_t sz_color;
message->FindData("color",B_RGB_COLOR_TYPE,(const void**)&rgb,&
sz_color);=20
Create two methods in common.cpp
char * getDateStr(char *str, const char *format, int size);
char * getTimeStr(char *str, const char *format, int size);
What do tou guys think?
|
|
From: Sir M. <obe...@ho...> - 2004-03-27 15:34:13
|
Aloha Daniel,
>Hello. I found a few problem with some of the changes.
>The problem lays in that the MSN protocol uses the charset=UTF8 and so
>does BeOS for all the GUI text displaying classes. The problem is that
>BString cannot handle UTF8. So when you get the message body like this:
> BString im;
> message->FindString("body",&im);
>you get some problems for most of other non ascii characters, for
>example á,é,í,ó,ú, ñ (If you don't see this character change the
>encoding of the e-mail to Latin-1). I use these chars a lot since most
>of my conversations are in spanish. I think the best way to handle
>messages is to use char pointers instead of BStrings, to avoid any
>problems with character encodings.
Ohoh...didn't know that...the guys at BeShare said that the BStrings would
handle UTF8 well....so it does not...I never experienced those problems
because those characters aren't used much here...I changed it to BString
because the BString code is better organized, has more options and is a lot
easier than those c methods, which I find quite difficult to use....but if
it can't be done with BStrings then we have to use char* code...btw, what
about c++ strings? can they be used, they are object oriented to and have
most of the methods a BString has...or maybe implement our own version of a
BString using the c methods?
>
>On a separate note, some suggetions for changes
>
>Maybe move the "\r\n" replacing code to the MsnSBHandler to make the
>MsnChatter easier, clearer more straight forward, doing all the hard
>work in the Protocol classes.
>
Ah ok! it was more a quick fix for those problems, your suggestion is
better...btw, we have to try if we have to change the sending code to...so
we change the beOS \n to \r\n....so testing is needed where one person uses
MSN 6.0...
>into this:
> rgb_color rgb = rgb_color();
> msg.AddData("color",B_RGB_COLOR_TYPE,(const void*)&
>rgb,sizeof(rgb));
> ...
> const rgb_color *rgb; ssize_t sz_color;
> message->FindData("color",B_RGB_COLOR_TYPE,(const void**)&rgb,&
>sz_color);
>
I just copied your code...let's change it to this indeed...where is the
rgb_color code located btw? maybe I then can work on choosing a color ,font,
etc too...
>Create two methods in common.cpp
>char * getDateStr(char *str, const char *format, int size);
>char * getTimeStr(char *str, const char *format, int size);
>
>What do tou guys think?
>
Ok with me...btw another suggestion from me...I'm working on another beOS
project and I use constants in this way:
namespace Messages
{
const uint32 START_SIMULATION = 'STsi';
const uint32 STOP_SIMULATION = 'SPsi';
const uint32 SIMULATION_SETTINGS = 'SIse';
const uint32 SET_SIMULATION_SETTINGS = 'STss';
const uint32 NEW_CAMERA_DATA = 'NEcd';
const uint32 UPDATE_MSG = 'UPms';
const uint32 UPDATE_FAILURE = 'UPfa';
const uint32 NEW_COORDINATES = 'NEco';
}
other constants are in other namespace, I personally prefer this approach to
the c #define part because it's easier to understand...what do you think?
also I would prefer putting the methods in common.cpp in a namespace because
you can see that it's a method from common.cpp a lot easier:
old: thismethod();
new: Common::thismethod();
what do you think? I know it's quite a job to change all the #defines to
namespace...but I'm willing to change the code in that way...if you agree
with it....
regards,
Tim
_________________________________________________________________
Hotmail en Messenger on the move
http://www.msn.nl/communicatie/smsdiensten/hotmailsmsv2/
|
|
From: Daniel G. <al7...@ma...> - 2004-03-27 19:01:50
|
Hi again.
> >Hello. I found a few problem with some of the changes.
> >The problem lays in that the MSN protocol uses the charset=3DUTF8 and=20
> > so
> >does BeOS for all the GUI text displaying classes. The problem is=20
> > that
> >BString cannot handle UTF8. So when you get the message body like=20
> > this:
> > BString im;
> > message->FindString("body",&im);
> >you get some problems for most of other non ascii characters, for
> >example =E1,=E9,=ED,=F3,=FA, =F1 (If you don't see this character chan=
ge the
> >encoding of the e-mail to Latin-1). I use these chars a lot since=20
> > most
> >of my conversations are in spanish. I think the best way to handle
> >messages is to use char pointers instead of BStrings, to avoid any
> >problems with character encodings.
> Ohoh...didn't know that...the guys at BeShare said that the BStrings=20
> would=20
> handle UTF8 well....so it does not...I never experienced those=20
> problems=20
> because those characters aren't used much here...I changed it to=20
> BString=20
> because the BString code is better organized, has more options and is=20
> a lot=20
> easier than those c methods, which I find quite difficult to=20
> use....but if=20
> it can't be done with BStrings then we have to use char* code...btw,=20
> what=20
> about c++ strings? can they be used, they are object oriented to and=20
> have=20
> most of the methods a BString has...or maybe implement our own=20
> version of a=20
> BString using the c methods?
>=20
I worked the problem!! The BString works good, the only problem was=20
that you ware using CountChars() to insert the message into the=20
TextView. I changed it to insertion.Length() and fix the problem, no=20
more ugly squares or missing chars, so I think we are good with=20
BStrings as long a we keep in mind this problem.
>
> Ok with me...btw another suggestion from me...I'm working on another=20
> beOS=20
> project and I use constants in this way:
>=20
> namespace Messages
> {
> const uint32 START_SIMULATION =3D 'STsi';
> const uint32 STOP_SIMULATION =3D 'SPsi';
> const uint32 SIMULATION_SETTINGS =3D 'SIse';
>=20
> const uint32 SET_SIMULATION_SETTINGS =3D 'STss';
> const uint32 NEW_CAMERA_DATA =3D 'NEcd';
>=20
> const uint32 UPDATE_MSG =3D 'UPms';
> const uint32 UPDATE_FAILURE =3D 'UPfa';
> const uint32 NEW_COORDINATES =3D 'NEco';
> }
>=20
> other constants are in other namespace, I personally prefer this=20
> approach to=20
> the c #define part because it's easier to understand...what do you=20
> think?=20
> also I would prefer putting the methods in common.cpp in a namespace=20
> because=20
> you can see that it's a method from common.cpp a lot easier:
>=20
> old: thismethod();
> new: Common::thismethod();
>=20
> what do you think? I know it's quite a job to change all the=20
> #defines to=20
> namespace...but I'm willing to change the code in that way...if you=20
> agree=20
> with it....
>=20
I agree with using namespace.=20
For instance, MsnProtocolConstants, MsnProtocolMessages,=20
MsnProtocolCommands, etc, etc...
I can start making the changes for the Common namespace
|
|
From: Simon T. <sim...@ga...> - 2004-03-28 11:28:17
|
> Aloha Daniel,
>
> >Hello. I found a few problem with some of the changes.
> >The problem lays in that the MSN protocol uses the charset=3DUTF8 and
> > so
> >does BeOS for all the GUI text displaying classes. The problem is
> > that
> >BString cannot handle UTF8. So when you get the message body like
> > this:
> > BString im;
> > message->FindString("body",&im);
> >you get some problems for most of other non ascii characters, for
> >example =E1,=E9,=ED,=F3,=FA, =F1 (If you don't see this character change the
> >encoding of the e-mail to Latin-1). I use these chars a lot since
> > most
> >of my conversations are in spanish. I think the best way to handle
> >messages is to use char pointers instead of BStrings, to avoid any
> >problems with character encodings.
> Ohoh...didn't know that...the guys at BeShare said that the BStrings
> would
> handle UTF8 well....so it does not...I never experienced those
> problems
> because those characters aren't used much here...I changed it to
> BString
> because the BString code is better organized, has more options and is
> a lot
> easier than those c methods, which I find quite difficult to
> use....but if
> it can't be done with BStrings then we have to use char* code...btw,
> what
> about c++ strings=3F can they be used, they are object oriented to and
> have
> most of the methods a BString has...or maybe implement our own
> version of a
> BString using the c methods=3F
I'm too late; I see Daniel already has it figured out. A BString is
really just a variable size char array, with some extra methods and
things, but it makes no assumptions about the encoding, so CountChars
just returns the number of bytes. It's no big deal to add UTF-8
handling, as Daniel has done.
About using BStrings at all - if there is a lot of string manipulation
to be done, I agree that BStrings are easier (I used it quite a lot in
my emoticon-enabled text view), but if you don't need to do much to the
string I would prefer if it was kept as a char* to reduce overhead.
> >
> >On a separate note, some suggetions for changes
> >
> >Maybe move the "\r\n" replacing code to the MsnSBHandler to make the
> >MsnChatter easier, clearer more straight forward, doing all the hard
> >work in the Protocol classes.
> >
> Ah ok! it was more a quick fix for those problems, your suggestion is
> better...btw, we have to try if we have to change the sending code
> to...so
> we change the beOS \n to \r\n....so testing is needed where one
> person uses
> MSN 6.0...
Beat me to that as well! I was going to mention converting from \n to \
r\n before sending, and moving it into the protocol code. Great minds
think alike :D
> >into this:
> > rgb=5Fcolor rgb =3D rgb=5Fcolor();
> > msg.AddData("color",B=5FRGB=5FCOLOR=5FTYPE,(const void*)&
> >rgb,sizeof(rgb));
> > ...
> > const rgb=5Fcolor *rgb; ssize=5Ft sz=5Fcolor;
> > message->FindData("color",B=5FRGB=5FCOLOR=5FTYPE,(const void**)&rgb,&
> >sz=5Fcolor);
> >
> I just copied your code...let's change it to this indeed...where is
> the
> rgb=5Fcolor code located btw=3F maybe I then can work on choosing a color
> ,font,
> etc too...
>
> >Create two methods in common.cpp
> >char * getDateStr(char *str, const char *format, int size);
> >char * getTimeStr(char *str, const char *format, int size);
> >
> >What do tou guys think=3F
> >
> Ok with me...btw another suggestion from me...I'm working on another
> beOS
> project and I use constants in this way:
>
> namespace Messages
> {
> const uint32 START=5FSIMULATION =3D 'STsi';
> const uint32 STOP=5FSIMULATION =3D 'SPsi';
> const uint32 SIMULATION=5FSETTINGS =3D 'SIse';
>
> const uint32 SET=5FSIMULATION=5FSETTINGS =3D 'STss';
> const uint32 NEW=5FCAMERA=5FDATA =3D 'NEcd';
>
> const uint32 UPDATE=5FMSG =3D 'UPms';
> const uint32 UPDATE=5FFAILURE =3D 'UPfa';
> const uint32 NEW=5FCOORDINATES =3D 'NEco';
> }
Erm I suppose that's OK - uses more memory though I think.
> other constants are in other namespace, I personally prefer this
> approach to
> the c #define part because it's easier to understand...what do you
> think=3F
> also I would prefer putting the methods in common.cpp in a namespace
> because
> you can see that it's a method from common.cpp a lot easier:
>
> old: thismethod();
> new: Common::thismethod();
Yes have the common stuff in a new namespace, I'd like to reduce the
number of "common" methods and things as much as possible though.
> what do you think=3F I know it's quite a job to change all the
> #defines to
> namespace...but I'm willing to change the code in that way...if you
> agree
> with it....
OK by me.
> regards,
>
> Tim
|
|
From: Simon T. <sim...@ga...> - 2004-03-23 11:43:08
|
> Hi Daniel, > > I have some problems logging in, I do this: > > ssh -l sirmik cvs.sourceforge.net > > and this is what it says: > > Host key not found from the list of known hosts. > Are you sure you want to continue connecting (yes/no)? You have to type "yes" in full - it should then prompt you for a password. > if I choose yes or no I get the same message again. Do you know what > I'm > doing wrong. Btw, if I have the code from cvs I will make a doxygen > file for > it. Then we maybe should also make a directory for the docs generated > by > doxygen, Sounds cool. > regards, > > Tim Simon |