Re: [Blosxom-devel] Blosxom2 CPAN plugin support

[Gavin C. <ga...@op...>]

On Tue, Aug 28, 2007 at 01:16:57AM -0700, Bill Ward wrote:
> On 8/27/07, Gavin Carr <ga...@op...> wrote:
> > On Mon, Aug 27, 2007 at 05:10:26PM -0700, Bill Ward wrote:
> > > Clever!
> > > So you just create a zero-byte file in your plugins directory?  What
> > > if the file is not empty?  I'd add a test for -z there, and if it has
> > > anything in it, assume it's a traditional plugin.
> >
> > My patch just uses the plugin name to distinguish traditional plugins
> > and CPAN plugins (a '::' string, specifically), so a non-empty file wouldn't
> > be loaded, because it's looking for a hierarchical Blosxom/Plugin/Blosphemy.pm
> > version.
> >
> > Adding the -z test is easy though - I guess you're thinking that's just less
> > surprising if someone just copies a CPAN module straight into the plugins
> > directory?
> 
> I just want to make sure it's unambiguous.  The way your patch is
> written, a plugin placed into that directory that happens to contain
> :: characters will cause it to look in @INC.  If you add the -z test,
> then you have my vote for the cvs commit.

Ok, so committed, including suggested -z test.

Cheers,
Gavin