Menu

#15 Client option idea "lineWidth"

open
nobody
None
5
2010-05-16
2010-05-16
Anonymous
No

How about adding a (x11-) client option to paint wider lines? Greater line_width (e.g. 2) may improve visibility
on high resolution displays. I noticed that lines are very (/too) thin while using a high resolution on a relatively
small display.

To test a greater line width, change in
src/client/x11/xinit.c -> Init_top()
the line
xgc.line_width = 0;
to e.g.
xgc.line_width = 2;

Angeba

Discussion

  • Nobody/Anonymous

    Generally the -linewidth client option seems to work. Thanks for that!

    Just noticed that it does not seem to work at all with polygon maps!

    _Slightly_ annoying is, that the line width is not correctly updated when
    skipping backwards in recordings.

    Angeba

     
  • Nobody/Anonymous

    *** Line width is reset to 0 when displaying missiles/lasers. ***

    Verified with the x11 and ng-x11 clients. The sdl
    client does not seem to be affected (not tested).
    After painting any missile (smart, heat, torp),
    Gui_paint_missiles_end() sets the line width in the
    gameGC graphics context to 0, disregarding any other
    setting via the -lineWidth client option.

    The same applies to laser beams and
    Gui_paint_lasers_end().

    Other interfering calls to XSetLineAttributes():

    In
    src/client/x11/guimap.c: Gui_paint_polygon(),
    and (of course) also in
    src/client/ng-x11/guimap.c: Gui_paint_polygon().
    Also the sdl client seems to be affected here
    src/client/sdl/sdlgui.c: Gui_paint_polygon().

    These should be the reasons why the lineWidth option
    does not work on polygon maps so far.

    I may try to resolve these problems later, currently I am doing other stuff.

    Angeba

     

Log in to post a comment.

MongoDB Logo MongoDB