Re: blob_item patch

[Erik M. <J.A...@it...>]

On Thu, Nov 27, 2003 at 10:06:09AM -0700, Russ Dill wrote:
> This patch gets rid of all the kernelSize, kernelType, paramSize, etc
> defines in blob_status_t and replaces them each with a blob_item_t
> struct:
>=20
> typedef struct {
>         int size;
>         block_source_t type;
>         u32 *addr;
>         u32 md5_digest[4];
> } blob_item_t;
>=20
> This helps generalize and simplify a lot of the code. Let me know what
> you think of the patch.

Looks good to me.

diffstat output:
 include/blob/download.h   |    1=20
 include/blob/main.h       |   26 ++++----
 src/blob/flash-commands.c |   35 +++--------
 src/blob/linux.c          |   10 +--
 src/blob/load_kernel.c    |    7 +-
 src/blob/main.c           |   94 +++++++++++--------------------
 src/blob/reboot.c         |    2=20
 src/lib/download.c        |  137 ++++++++++++++++++++++-------------------=
-----=20
8 files changed, 131 insertions(+), 181 deletions(-)

It removes more than it adds, so it simplifies the code. Looks OK to
me.


Erik

--=20
Erik Mouw
J.A...@it...  mo...@nl...