From: Marc S. <el...@bu...> - 2003-10-02 19:43:43
|
So, are you saying that the code for the Sharp boards got integrated already? If so, I'd really appreciate a snapshot from CVS. On Thu, Oct 02, 2003 at 03:16:21PM -0400, Brad Parker wrote: > > Hi > > I made some changes to the blob+lineo code for my A400 board and got > disgusted and did some refactoring of their code (mostly to look the > 4,000,000 #ifdef's they put everywhere). > > Then, while working on an xscale project I noticed the latest blob cvs > seems to have done a lot of this refactoring already and integrated some > new cpu's cleanly. > > So I add "put your changes into the newest blob cvs" to my to-do list and > promptly started ignoring it :-) > > My biggest beef with the lineo code is the use of "LH7A400" when they > really ment KEV7A400 and "LH79520" when they really ment KEV79520. > i.e. mixing the notion of the cpu with the board instantiation as if there > would only ever be one A400 board in the world. A common mistake. The uboot code is much much worse. > > So if some/any/all of the lineo code gets put in, please define the > Sharp eval boards as KEV7A400 and KEV79520 like this snipped below > (from configure) > > ... > cat >> confdefs.h <<\EOF > #define LH79520 1 > EOF > > BLOB_PLATFORM_OBJ="kev79520.o" > BLOB_FLASH_OBJS="sharp_lh28f320.o" > use_cpu="lh79520" > ... > > that way we can have multiple boards which use the same cpu and not all > pull our hair out. > > I sure you know all this, and sorry for the rant - I had some pent up > frustration I needed to release :-) I've been very restrained about criticizing those who came before me. Their code has always been welcome as it lightens my burden. Yet, I too have found the Lineo work wanting > > [and having said that, I'm happy to build and test blob for the KEV79520 > and KEV7A400 since I have one of each right now, as well as my own A400 > board] Good to know. I rewrote the memory initialization code once already. I'll do so again as soon as I can get something running on the KEV7A400. |