Re: CVS: blob/src/blob ledasm.S,1.3,1.4

[Erik M. <J.A...@it...>]

On Thu, Jul 25, 2002 at 10:24:38AM -0700, Christopher Hoover wrote:
> Update of /cvsroot/blob/blob/src/blob
> In directory usw-pr-cvs1:/tmp/cvs-serv24870
> 
> Modified Files:
> 	ledasm.S 
> Log Message:
> prefix register offsets with _ so as to not conflict with sa1100.h defines
> 
> Index: ledasm.S
> ===================================================================
> RCS file: /cvsroot/blob/blob/src/blob/ledasm.S,v
> retrieving revision 1.3
> retrieving revision 1.4
> diff -u -d -r1.3 -r1.4
> --- ledasm.S	28 Oct 2001 20:29:05 -0000	1.3
> +++ ledasm.S	25 Jul 2002 17:24:36 -0000	1.4
> @@ -33,16 +33,15 @@
>  #endif
>  
>  #include <blob/arch.h>
> -
> -
> +#include <blob/sa1100.h>
   ^^^^^^^^^^^^^^^^^^^^^^^^
Unnecessary include.

>  .text
>  
>  LED:		.long LED_GPIO
>  GPIO_BASE:	.long 0x90040000
> -#define	GPDR	0x00000004
> +#define	_GPDR	0x00000004

Unnecessary cosmetical difference.

It already helps a *lot* when you don't include blob/sa1100.h in the
first place. We don't need it in assembly, I'd rather keep the stuff
readable instead of having unnecessary underscores before every
identifier. Please back out this patch (same for all the other .S
patches).


Erik

-- 
J.A.K. (Erik) Mouw
Email: J.A...@it...
WWW: http://www-ict.its.tudelft.nl/~erik/