Re: CVS: blob/src/blob compr_rtime.c,NONE,1.1 compr_rubin.c,NONE,1.1 compr_zlib.c,NONE,1.1 cramfs.c,NONE,1.1 jffs2.c,NONE,1.1 load_kernel.c,NONE,1.1 mini_inflate.c,NONE,1.1 zImage.c,NONE,1.1 Makefile.am,1.22,1.23 main.c,1.31,1.32

[Russ D. <Rus...@as...>]

> A couple of remarks:
> 
> - Be *extremely* careful with inline functions, they can really bloat
>   the generated code.
> - We already have quite some functions available. For example: I'd
>   rather have a generic memset() function in src/lib/ and #define
>   cramfs_memset as memset.

feel free, just as long as the memset() in src/lib operates on u8's and
not u32's. There are a lot of generic functions in there that can be
replaced.

> - What is ZIMAGE support supposed to do? I guess it's to load directly
>   from flash partitions, but in that case the name is wrong.

A zImage contains information on its length, this can be exploited for
slightly faster load times.

> - Checking for the ZIMAGE magic is a bad idea. It doesn't allow you to
>   load diag anymore, for example (yes, it has a hack to look like a
>   kernel, but that's ugly). Oh, and the so called "magic value" is
>   nowhere documented so don't rely on it.

The plan was to allow partitions to be identified in some way, the
fallback behavior being load a raw image from a default area.