Re: CVS: blob/src/commands call.c,NONE,1.1 changebit.c,NONE,1.1 chkmem.c,NONE,1.1 cmddebug.h,NONE,1.1 common.c,NONE,1.1 common.h,NONE,1.1 dump.c,NONE,1.1 memcpy.c,NONE,1.1 peek.c,NONE,1.1 poke.c,NONE,1.1 regs-sa11x0.c,NONE,1.1 Makefile.am,1.1,1.2

[Erik M. <J.A...@it...>]

On Tue, Feb 12, 2002 at 04:55:02AM -0800, Stefan Eletzhofer wrote:
> Update of /cvsroot/blob/blob/src/commands
> In directory usw-pr-cvs1:/tmp/cvs-serv23725
> 
> Modified Files:
> 	Makefile.am 
> Added Files:
> 	call.c changebit.c chkmem.c cmddebug.h common.c common.h 
> 	dump.c memcpy.c peek.c poke.c regs-sa11x0.c 
> Log Message:
> - added basic commands from diag and blob
> - each command got its own source file, so blob/diag
>   size will not blown up when cherry-picking commands
> - commands have to be removed from blob and diag in order
>   to take full advantage from this

Good, but be careful: not all commands should be shared between diag
and blob. For example: blob has commands to manipulate the flash, diag
hasn't (and doesn't need to). Diag should have functions that help
debug the board (memory tester, etc), blob shouldn't. Blob and diag are
two binaries with completely different purpose, be careful not to mix
them up.


Erik

-- 
J.A.K. (Erik) Mouw, Information and Communication Theory Group, Faculty
of Information Technology and Systems, Delft University of Technology,
PO BOX 5031, 2600 GA Delft, The Netherlands  Phone: +31-15-2783635
Fax: +31-15-2781843  Email: J.A...@it...
WWW: http://www-ict.its.tudelft.nl/~erik/