Re: CVS: blob/src/lib serial.c,1.7,1.8

[Abraham vd M. <ab...@2d...>]

Hi Erik!

> > Update of /cvsroot/blob/blob/src/lib
> > In directory usw-pr-cvs1:/tmp/cvs-serv15305/src/lib
> >=20
> > Modified Files:
> > 	serial.c=20
> > Log Message:
> > Added a printf()-like function for printing to the serial port. Also so=
me
> > minor code cleanup in the memory checking routines.
>=20
> I'd prefer if you could move it to src/lib/printf.c and just call the
> function printf(). No difference in functionality, but it makes the
> source easier to browse and to read.

As you might have seen, I backed out the changes in anycase since there's no
portable way to do variable arguments (I realised that after I wrote the
damn function) and we don't include the standard C library headers.

I looked at the way diet libc does it's stdarg.h, but that is a great
example of why you don't want to write your own stdarg routines :P (Besides
the fact that those routines doesn't work for uncast numeric parameters e.g.
printf("%x",15); )

> PS: If this is Brad Parker's printf() be sure to put a correct
>   copyright on top of the file. The last thing we want is copyright
>   issues.

No, I wrote that one yesterday.

--=20

Regards
 Abraham

He knows not how to know who knows not also how to unknow.
		-- Sir Richard Burton

__________________________________________________________
 Abraham vd Merwe - 2d3D, Inc.

 Device Driver Development, Outsourcing, Embedded Systems

  Cell: +27 82 565 4451         Snailmail:
   Tel: +27 21 761 7549            Block C, Antree Park
   Fax: +27 21 761 7648            Doncaster Road
 Email: ab...@2d...         Kenilworth, 7700
  Http: http://www.2d3d.com        South Africa