blob-cvs-commit

CVS: blob/src/blob main.c,1.35,1.36

[Stefan E. <se...@us...>]

Update of /cvsroot/blob/blob/src/blob
In directory usw-pr-cvs1:/tmp/cvs-serv6997

Modified Files:
	main.c 
Log Message:
make 115k2 default for system 3 too


Index: main.c
===================================================================
RCS file: /cvsroot/blob/blob/src/blob/main.c,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -d -r1.35 -r1.36
--- main.c	17 Feb 2002 15:41:54 -0000	1.35
+++ main.c	21 Feb 2002 14:21:35 -0000	1.36
@@ -93,11 +93,8 @@
 
 	/* call serial_init() because the default 9k6 speed might not
            be what the user requested */
-#if defined(H3600) || defined(SHANNON) || defined(IDR) || defined(BADGE4) || defined(JORNADA720) || defined(ACCELENT_SA)
+#if defined(H3600) || defined(SHANNON) || defined(IDR) || defined(BADGE4) || defined(JORNADA720) || defined(ACCELENT_SA) || defined(PT_SYSTEM3)
 	blob_status.terminalSpeed = baud_115200; /* DEBUG */
-#endif
-#if defined(PT_SYSTEM3)
-	blob_status.terminalSpeed = baud_38400;
 #endif
 	serial_init(blob_status.terminalSpeed);
 

RE: blob/src/blob main.c,1.35,1.36

[Christopher H. <ch...@mu...>]

Wouldn't we be better off with a #define in <platform>.h for the default
terminal baud rate rather than this ever-growing #if expression?

-ch


> -----Original Message-----
> From: blo...@li... 
> [mailto:blo...@li...] On 
> Behalf Of Stefan Eletzhofer
> Sent: Thursday, February 21, 2002 6:22 AM
> To: blo...@li...
> Subject: CVS: blob/src/blob main.c,1.35,1.36
> 
> 
> Update of /cvsroot/blob/blob/src/blob
> In directory usw-pr-cvs1:/tmp/cvs-serv6997
> 
> Modified Files:
> 	main.c 
> Log Message:
> make 115k2 default for system 3 too
> 
> 
> Index: main.c 
> ===================================================================
> RCS file: /cvsroot/blob/blob/src/blob/main.c,v
> retrieving revision 1.35
> retrieving revision 1.36
> diff -u -d -r1.35 -r1.36
> --- main.c	17 Feb 2002 15:41:54 -0000	1.35
> +++ main.c	21 Feb 2002 14:21:35 -0000	1.36
> @@ -93,11 +93,8 @@
>  
>  	/* call serial_init() because the default 9k6 speed might not
>             be what the user requested */
> -#if defined(H3600) || defined(SHANNON) || defined(IDR) || 
> defined(BADGE4) || defined(JORNADA720) || defined(ACCELENT_SA)
> +#if defined(H3600) || defined(SHANNON) || defined(IDR) || 
> +defined(BADGE4) || defined(JORNADA720) || 
> defined(ACCELENT_SA) || defined(PT_SYSTEM3)
>  	blob_status.terminalSpeed = baud_115200; /* DEBUG */
> -#endif
> -#if defined(PT_SYSTEM3)
> -	blob_status.terminalSpeed = baud_38400;
>  #endif
>  	serial_init(blob_status.terminalSpeed);
>  
> 
> 
> _______________________________________________
> blob-cvs-commit mailing list blo...@li...
> https://lists.sourceforge.net/lists/listinfo/blob-cvs-commit
> 

Re: blob/src/blob main.c,1.35,1.36

[Stefan E. <ste...@el...>]

On Thu, Feb 21, 2002 at 01:18:38PM -0800, Christopher Hoover wrote:
> 
> Wouldn't we be better off with a #define in <platform>.h for the default
> terminal baud rate rather than this ever-growing #if expression?

Yup, indeed :^)

> 
> -ch
> 
> 

Re: blob/src/blob main.c,1.35,1.36

[Erik M. <J.A...@it...>]

On Thu, Feb 21, 2002 at 01:18:38PM -0800, Christopher Hoover wrote:
> Wouldn't we be better off with a #define in <platform>.h for the default
> terminal baud rate rather than this ever-growing #if expression?

Even better is to let it default to 9k6 and override it with a
parameter block setting.


Erik

-- 
J.A.K. (Erik) Mouw, Information and Communication Theory Group, Faculty
of Information Technology and Systems, Delft University of Technology,
PO BOX 5031, 2600 GA Delft, The Netherlands  Phone: +31-15-2783635
Fax: +31-15-2781843  Email: J.A...@it...
WWW: http://www-ict.its.tudelft.nl/~erik/

Re: blob/src/blob main.c,1.35,1.36

[Erik M. <J.A...@it...>]

On Fri, Feb 22, 2002 at 02:07:40PM +0100, Erik Mouw wrote:
> On Thu, Feb 21, 2002 at 01:18:38PM -0800, Christopher Hoover wrote:
> > Wouldn't we be better off with a #define in <platform>.h for the default
> > terminal baud rate rather than this ever-growing #if expression?
> 
> Even better is to let it default to 9k6 and override it with a
> parameter block setting.

Now that I'm thinking of it:

Russ, it might be a good idea to have a default parameter block
compiled into blob, much in the same way as I made a default partition
table (only in src/blob/lart.c right now). The default parameter block
would live in the architecture specific source file, so it doesn't
clutter up the rest of the code.


Erik

-- 
J.A.K. (Erik) Mouw, Information and Communication Theory Group, Faculty
of Information Technology and Systems, Delft University of Technology,
PO BOX 5031, 2600 GA Delft, The Netherlands  Phone: +31-15-2783635
Fax: +31-15-2781843  Email: J.A...@it...
WWW: http://www-ict.its.tudelft.nl/~erik/

Re: blob/src/blob main.c,1.35,1.36

[Stefan E. <ste...@el...>]

On Fri, Feb 22, 2002 at 02:38:05PM +0100, Erik Mouw wrote:
> On Fri, Feb 22, 2002 at 02:07:40PM +0100, Erik Mouw wrote:
> > On Thu, Feb 21, 2002 at 01:18:38PM -0800, Christopher Hoover wrote:
> > > Wouldn't we be better off with a #define in <platform>.h for the default
> > > terminal baud rate rather than this ever-growing #if expression?
> > 
> > Even better is to let it default to 9k6 and override it with a
> > parameter block setting.
> 
> Now that I'm thinking of it:
> 
> Russ, it might be a good idea to have a default parameter block
> compiled into blob, much in the same way as I made a default partition
> table (only in src/blob/lart.c right now). The default parameter block
> would live in the architecture specific source file, so it doesn't
> clutter up the rest of the code.

Ah, that would be nice!

> 
> 
> Erik
> 
> -- 
> J.A.K. (Erik) Mouw, Information and Communication Theory Group, Faculty
> of Information Technology and Systems, Delft University of Technology,
> PO BOX 5031, 2600 GA Delft, The Netherlands  Phone: +31-15-2783635
> Fax: +31-15-2781843  Email: J.A...@it...
> WWW: http://www-ict.its.tudelft.nl/~erik/
> 
> _______________________________________________
> blob-cvs-commit mailing list
> blo...@li...
> https://lists.sourceforge.net/lists/listinfo/blob-cvs-commit