bitpim-devel — For bitpim developers

[Bitpim-devel] BitPim info in a file on the phone

[Roger B. <ro...@ro...>]

There would be some things that would make some bitpim code easier
if per phone preferences were available.  There are two places that
information can be stored.

One is within the BitPim preferences on a host machine (ie registry
on Windows, ~/.bitpim on Linux and Mac).

The other is I could put a file onto the phone's filesystem with the
information.

The latter approach is nice and simple, and lets you use as many
computers with BitPim as you want.  However it does mean a 3rd party
can tell if you use BitPim with a phone.  There is also the small 
potential to harm a phone.  For example if someone has filled up
all but 10 bytes of the EFS and BitPim then writes in a 20 byte
file, that may shaft the phone in various interesting ways.  It
wouldn't have happened if BitPim didn't save information on the 
phone.

Note that I am not doing this yet, just fishing for thoughts and
exploring the issue.

Here are two examples of information I would like to store:

 - Is the phonebook stored by Last Name First Name or First Name
   Last Name
 - A per category ringtone

Roger

Re: [Bitpim-devel] ntp

[Roger B. <ro...@ro...>]

> The phone gets its time from the cell towers which use GPS receivers (they
> have atomic clocks on the satellites) or from another NTP server.

Then there was the one time I was at the Los Angeles Convention Center and
the tower in the CC was out by an hour (hadn't adjusted for daylight savings).
Clock on the phone kept changing depending where you were in the building.

Roger

Re: [Bitpim-devel] ntp

[Jim <Ji...@ja...>]

The phone gets its time from the cell towers which use GPS receivers (they
have atomic clocks on the satellites) or from another NTP server.

Seems to me you like that the other way around.  If you are seeing a time
discrepancy on your phone against a trusted source (i.e. an atomic clock) then
contact your provider about this.

Jim West
www.jameswest.com

The box said Windows 95 or better, so I installed Linux.


---------- Original Message -----------
From: "Somerlot, Chris" <CSo...@Br...>
To: "'bit...@li...'" <bit...@li...>
Sent: Tue, 13 Jan 2004 05:08:55 -0800
Subject: [Bitpim-devel] ntp

> Is there a way to update the time on the phone through the 
> interface? I'm wondering if there is a way to implement a update 
> from an ntp server?
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Perforce Software.
> Perforce is the Fast Software Configuration Management System 
> offering advanced branching capabilities and atomic changes on 50+ platforms.
> Free Eval! http://www.perforce.com/perforce/loadprog.html
> _______________________________________________
> Bitpim-devel mailing list
> Bit...@li...
> https://lists.sourceforge.net/lists/listinfo/bitpim-devel
------- End of Original Message -------

[Bitpim-devel] ntp

[Somerlot, C. <CSo...@Br...>]

Is there a way to update the time on the phone through the interface? I'm
wondering if there is a way to implement a update from an ntp server?

RE: [Bitpim-devel] 0.7 test1 notes

[John H. <mrm...@my...>]

I know someone mentioned that sanyo 4900 media support would be added very soon.

Please post to the list when that is the case:)

_______________________________________________
No banners. No pop-ups. No kidding.
Introducing My Way - http://www.myway.com

Re: [Bitpim-devel] Re: com/modem port detection

[Steven P. <n9...@n9...>]

On Jan 12, 2004, at 1:13 AM, Roger Binns wrote:
> Generally mark everything as serial unless you know it is a modem.
>
> The Sanyo phones are only modem.  The LG should present a modem and a
> serial interface, and they should be marked as such (so the autodetect
> code picks/excludes the right thing).

  Maybe we're not on the same page here....

  When I'm just scanning a list of devices that exist in the /dev 
filesystem, how am I to know what is or is not a modem or serial 
interface? That was my question. I can't be assured that the chosen 
string by the vendor will be representative of the actual use of the 
device.

  The LG phone on my creates a /dev/cu.usbmodemXXX and a 
/dev/tty.usbmodemXXX entry. There is no "serial" interface created as 
such. Now, in the case of the KeySpan adapter (which you may have 
connected and have found some way to plug your phone in to this using 
some serial adapter cable combination), I have no idea what it is.

  At any rate, what logic are you using on Linux and/or Windows to know 
this information?  Are you just guessing as well, or does the system 
present more concrete information to you? How would the system tell me 
that it *is* a modem so I would know it's not serial?

  Sorry for the ignorance here, but I'm missing something.

-. ----. -.-- - -.--
Steve Palm - n9...@n9...
-. ----. -.-- - -.--

Re: [Bitpim-devel] Re: Re: com/modem port detection

[Roger B. <ro...@ro...>]

> I am not sure if this is the right place to do so,

Techie information is always welcome.

> Anyways, I have a Sanyo SCP-5500 (Readylink/video phone) and the USB
> device ID shows up the same as the SCP-4900 listed in com_sanyo.py.

It looks like they use the same pid for all Sanyo USB phones, which
is nice.

> Here is the error for example when trying to import the phonebook
> (latest CVS checkout around 1AM 01/12/04):

It will be more helpful if you also turn on the protocol logging.

Roger

Re: [Bitpim-devel] Re: com/modem port detection

[Roger B. <ro...@ro...>]

>   Since this is so arbitrary, depending on the vendor's driver and
> choice of text string they use when constructing the name, I'd hesitate
> to code to it, it's not quite a standard. However, if there is a choice
> that must be made to make things work properly I guess we can just punt
> and hope for the best.

Generally mark everything as serial unless you know it is a modem.

The Sanyo phones are only modem.  The LG should present a modem and a
serial interface, and they should be marked as such (so the autodetect
code picks/excludes the right thing).

Roger

[Bitpim-devel] Re: Re: com/modem port detection

[Adit P. <apa...@ba...>]

Hi all,

I have been monitoring this project for a little while and thought I 
might share some input. I am not sure if this is the right place to do 
so, since I am not a member of the development team. I know how to code, 
but I have not dabbled in Python before. I downloaded the appropriate 
libraries, and have fiddled around with the code a little.

Anyways, I have a Sanyo SCP-5500 (Readylink/video phone) and the USB 
device ID shows up the same as the SCP-4900 listed in com_sanyo.py. I am 
using the FutureDial drivers and the phone works in other programs. I 
have been successful in getting the filesystem view to work, but I get 
an error when trying to import any kind of data.

Here is the output of what USB View says for my phone:

Device Descriptor:
bcdUSB:             0x0101
bDeviceClass:         0x02
bDeviceSubClass:      0x00
bDeviceProtocol:      0x00
bMaxPacketSize0:      0x08 (8)
idVendor:           0x0474 (Sanyo Electric Co. Ltd.)
idProduct:          0x0701
bcdDevice:          0x0000
iManufacturer:        0x01
iProduct:             0x02
iSerialNumber:        0x03
bNumConfigurations:   0x01

Here is the error for example when trying to import the phonebook 
(latest CVS checkout around 1AM 01/12/04):

Traceback (most recent call last):
   File "C:\projects\bitpim\bitpim\gui.py", line 148, in run
     res=call()
   File "C:\projects\bitpim\bitpim\gui.py", line 89, in __call__
     return apply(self.method, self.args+args, d)
   File "C:\projects\bitpim\bitpim\gui.py", line 1037, in getdata
     i[1](results)
   File "C:\projects\bitpim\bitpim\com_sanyo.py", line 218, in getphonebook
     buf=prototypes.buffer(self.getsanyobuffer(sortstuff.startcommand, 
sortstuff.bufsize, "sort buffer"))
   File "C:\projects\bitpim\bitpim\com_sanyo.py", line 98, in getsanyobuffer
     res=self.sendpbcommand(req, p_sanyo.bufferpartresponse);
   File "C:\projects\bitpim\bitpim\com_sanyo.py", line 133, in sendpbcommand
     self.setmode(self.MODEPHONEBOOK)
   File "C:\projects\bitpim\bitpim\com_phone.py", line 96, in setmode
     res=getattr(self, func)()
   File "C:\projects\bitpim\bitpim\com_sanyo.py", line 70, in 
_setmodephonebook
     self.sendpbcommand(req, respc, callsetmode=False)
   File "C:\projects\bitpim\bitpim\com_sanyo.py", line 163, in sendpbcommand
     res.readfrombuffer(buffer)
   File "C:\projects\bitpim\bitpim\p_sanyo.py", line 213, in readfrombuffer
     self.__field_date3.readfrombuffer(buf)
   File "C:\projects\bitpim\bitpim\prototypes.py", line 320, in 
readfrombuffer
     self._value=buf.getnextbytes(self._sizeinbytes)
   File "C:\projects\bitpim\bitpim\prototypes.py", line 766, in getnextbytes
     raise IndexError("Trying to read "+`howmany`+" bytes starting at 
"+`self._offset`+" which will go beyond end of "+`len(self._data)`+" 
byte buffer")
IndexError: Trying to read 11 bytes starting at 48 which will go beyond 
end of 55 byte buffer

Variables by last 6 frames, innermost last

Frame setmode in C:\projects\bitpim\bitpim\com_phone.py at line 98
     desiredmode =  'modephonebook'
            self =  <com_sanyo8100.Phone instance at 0x019E0E68>
         strmode =  'brew'
  strdesiredmode =  'phonebook'
            func =  '_setmodephonebook'
               v =  'writefile'

Frame _setmodephonebook in C:\projects\bitpim\bitpim\com_sanyo.py at line 73
            self =  <com_sanyo8100.Phone instance at 0x019E0E68>
             req =  <p_sanyo.firmwarerequest object at 0x019CE9B0>
           respc =  <class 'p_sanyo.firmwareresponse'>

Frame sendpbcommand in C:\projects\bitpim\bitpim\com_sanyo.py at line 163
       writemode =  False
               d =  -1
   responseclass =  <class 'p_sanyo.firmwareresponse'>
          buffer =  <prototypes.buffer instance at 0x019EADA0>
             res =  <p_sanyo.firmwareresponse object at 0x019CE1F0>
     callsetmode =  False
        firsttwo =  '\x00x'
         request =  <p_sanyo.firmwarerequest object at 0x019CE9B0>
            data =  '\x00Oct 30 200316:13:13Feb 17 200309:00:00SCP5500 
j\x06\x16
            self =  <com_sanyo8100.Phone instance at 0x019E0E68>
        numretry =  0

Frame readfrombuffer in C:\projects\bitpim\bitpim\p_sanyo.py at line 213
             buf =  <prototypes.buffer instance at 0x019EADA0>
            self =  <p_sanyo.firmwareresponse object at 0x019CE1F0>
            dict =  {'sizeinbytes': 11, 'terminator': None}

Frame readfrombuffer in C:\projects\bitpim\bitpim\prototypes.py at line 320
            self =  <prototypes.STRING object at 0x019CE390>
             buf =  <prototypes.buffer instance at 0x019EADA0>

Frame getnextbytes in C:\projects\bitpim\bitpim\prototypes.py at line 766
            self =  <prototypes.buffer instance at 0x019EADA0>
         howmany =  11

I hope this helps for the project.

Adit

Re: [Bitpim-devel] Re: com/modem port detection

[Roger B. <ro...@ro...>]

> Will the usbids in com_sanyo.py prevent a phone with different ID's from
> working?

They won't be selected as part of auto guessing and they won't have  a (*)
next to them in the com port browser.

> If so, I should move the usbids to the 4900 specific code and
> leave it blank for phones that I don't know the id's for.

Yup.  The LG uses the same vid/pid for the 4400 and 6000.  I haven't
heard from anyone with other models.

If any of the phones use usb to serial cables, you will need their
vid/pid in there as well.

Roger

Re: [Bitpim-devel] Re: com/modem port detection

[Steven P. <n9...@n9...>]

On Jan 11, 2004, at 4:07 AM, Roger Binns wrote:
> Steven, can you please update the comscanmac function in comscan.py
> to note if the device is a serial or modem.  I think the Mac uses
> /dev/cu.usbserial and /dev/cu.usbmodem respectively.  res["class"]
> should be set the the right value in the loop.

  I'm not sure if it is that simple... Maybe it is for the 
drivers/cables commonly used for cell phones, but, for example, the 
very popular USB<-->Serial adapters made by KeySpan show up like this:

    - /dev/tty.KeyUSA28X<geo>1  -- or -- /dev/cu.KeyUSA28X<geo>1
    - /dev/tty.KeyUSA28X<geo>2  -- or -- /dev/cu.KeyUSA28X<geo>2

    where <geo> is the 2 or more digit geographical name.  (e.g. "913" 
means USB bus #9, host hub port #1 and external hub port #3)

  I did find a reference to the Prolific chipset and the driver they 
have for MacOS X does, as far as I can tell, use usbserial.

  Since this is so arbitrary, depending on the vendor's driver and 
choice of text string they use when constructing the name, I'd hesitate 
to code to it, it's not quite a standard. However, if there is a choice 
that must be made to make things work properly I guess we can just punt 
and hope for the best.

-. ----. -.-- - -.--
Steve Palm - n9...@n9...
-. ----. -.-- - -.--

Re: [Bitpim-devel] Re: com/modem port detection

[Stephen W. <sa...@us...>]

On Sun, 2004-01-11 at 05:07, Roger Binns wrote:
> The usb information is now in the profile for each phone class.  I put
> the sanyo entry into com_sanyo, so you will need to update that if
> it differs by model.

Will the usbids in com_sanyo.py prevent a phone with different ID's from
working?  If so, I should move the usbids to the 4900 specific code and
leave it blank for phones that I don't know the id's for.

Could one of the SCP-8100 owners get the USB id's for that phone.

Also, if there is anyone with a different Sanyo phone (5300 or the new
readylink or video phones), could you also post your USB ids along with
your phone model.

					Steve

Re: [Bitpim-devel] Splitting fullname into parts

[Stephen W. <sa...@us...>]

Evolution's got some File As button in it's contact editor.  It lets you
choose between "First Last" and "Last, First".

I found the "Western Name Parser" in evolution.  (Now in the
evolution-data-server).  It starts out with

* <Nat> Jamie, do you know anything about name parsing?
* <jwz> Are you going down that rat hole?  Bring a flashlight.

It looks like the relevant files are e-name-western.c, e-name-western.h
and e-name-western-tables.h.  They can be browsed at
http://cvs.gnome.org/lxr/source/evolution-data-server/addressbook/libebook/

					Steve

[Bitpim-devel] Re: com/modem port detection

[Roger B. <ro...@ro...>]

> 1.  Several windows users got stuck initially because BitPim didn't auto
> detect their phone and they didn't know what to do.  I can add some
> notes to the help, but is there anything else that can be done help
> users here?  (On my XP system, the port browser shows COM1 and COM2, but
> my phone is know to windows as a modem on COM4.)

I have now implemented the fix for this.  ports now have a "class" field
which is "serial" or "modem".  (The LG phones are on serial, the Sanyo
on modem).

The usb information is now in the profile for each phone class.  I put
the sanyo entry into com_sanyo, so you will need to update that if
it differs by model.

Steven, can you please update the comscanmac function in comscan.py
to note if the device is a serial or modem.  I think the Mac uses
/dev/cu.usbserial and /dev/cu.usbmodem respectively.  res["class"]
should be set the the right value in the loop.

Roger

Re: [Bitpim-devel] Splitting fullname into parts

[Roger B. <ro...@ro...>]

Stephen Wood wrote:
> Evolution seems to have some sort of algorithm.  I went into the contact
> editor (for V 1.2.2) and typed in "Don Juan De Marco" and then clicked
> on the "Full Name" button.  It split the name into Firts: Don, Middle:
> Juan, Last: De Marco, Suffix: III.

Outlook is even more fine tuned.  It splits the name correctly, but
also has a 'File As' field which is "lastname, first middle" format.
If the "de" is lower case, it is file as "Marco, Don Juan de" and
if "de" is upper case "De" then it is file as "De Marco, Don Juan".

Roger

Re: [Bitpim-devel] Splitting fullname into parts

[Stephen W. <sa...@ge...>]

Evolution seems to have some sort of algorithm.  I went into the contact
editor (for V 1.2.2) and typed in "Don Juan De Marco" and then clicked
on the "Full Name" button.  It split the name into Firts: Don, Middle:
Juan, Last: De Marco, Suffix: III.

I'll poke around to see if I can find the algorithm used.

			Steve

[Bitpim-devel] Splitting fullname into parts

[Roger B. <ro...@ro...>]

Does anyone have any pointers to an algorithm for splitting 
a full name into parts?

It should cope with something like:

 Don Juan De Marco III

The III is a generational qualifier and "De" is part
of the surname and is not a middle name.

Roger

Re: [Bitpim-devel] 0.7 test1 notes

[Roger B. <ro...@ro...>]

> 1.  Several windows users got stuck initially because BitPim didn't auto
> detect their phone and they didn't know what to do.  I can add some
> notes to the help, but is there anything else that can be done help
> users here?  (On my XP system, the port browser shows COM1 and COM2, but
> my phone is know to windows as a modem on COM4.)

Currently on Windows it only lists serial ports, not modems.  I did
experiment with a one line change and the modems are detected as
well.  However the modem is the wrong thing to pick for the LG phones.

The correct fix will be:

  - In the listing of ports, add in a 'class' that shows if the
    port is a com port or a modem
  - In the code that selects the device, it should pay attention
    to the class

> 3.  While it is explained in the help that media are not supported for
> the Sanyo phones, that is not clear from the application itself.  A user
> tried to download wallpaper and ringtones from his 4900 and got a python
> error.  Is there a way I can pop up an error, or can the
> wallpaper/ringer items in the get and send be disabled when they are not
> supported.

My intention was to have the wallpaper/ringtone panes removed if the
currently selected phone didn't support it.  It is actually going to
be considerably easier to just disable them, and the relevant portion
of the get/send dialogs.  (I currently detest the get/send dialog
so if you want to make something better, please volunteer or make
a suggested screenshot).  The per phone profile will then contain
information about what features the phone/bitpim supports.

> I have not be able to get a more descriptive error report
> than that yet.

I have had a few of those :-)  I did update the help for support
and now just point people at that.

http://bitpim.sourceforge.net/testhelp/support.htm

> I have tried to encourage people to report the experience on
> bitpim-user, but I think without too much success.

Yup, I have the same problem.  I get very impressed by the non-LG
people who mail me at the SourceForge address as well as the
address from the vx4400 FAQ on my website.

These things just take time, and will correct themselves with
enough gentle persuasion.  I always make sure I deal with stuff
on the bitpim groups first, and give more detailed and helpful
answers there.  Often I refuse to answer stuff in personal email
unless they post to the lists.  (If I am going to use my time
to answer stuff, it is way more beneficial for all involved
that everyone sees the answers, and can comment on the original
question and issues).

I will make an effort to fix both 1 & 3 before the next test 
release (I would like to do them every two weeks or so).  
However I may be out of action for up to a week.  I am having
some "oral surgery" (it sounds really wierd to me) to correct
some British dentistry.

Roger

[Bitpim-devel] 0.7 test1 notes

[Stephen W. <sa...@us...>]

I have gotten some feedback on the Sanyo phone support from sprintusers
and howardforums readers who have tried BitPim 0.7test1.

1.  Several windows users got stuck initially because BitPim didn't auto
detect their phone and they didn't know what to do.  I can add some
notes to the help, but is there anything else that can be done help
users here?  (On my XP system, the port browser shows COM1 and COM2, but
my phone is know to windows as a modem on COM4.)

2.  A MacOS user was successfull using BitPim with an 8100.

3.  While it is explained in the help that media are not supported for
the Sanyo phones, that is not clear from the application itself.  A user
tried to download wallpaper and ringtones from his 4900 and got a python
error.  Is there a way I can pop up an error, or can the
wallpaper/ringer items in the get and send be disabled when they are not
supported.

4.  A user reported success with the phonebook for the SCP-7200.  The
7200 is a newer Sprint Readylink (push to talk) phone.  He also reported
that he got an error when trying to download the calendar. 
Unfortunately, I have not be able to get a more descriptive error report
than that yet.  But this gives hope to my suspicion that it will be easy
for BitPim to support at least the phonebook for most of Sanyo's phones.


I have tried to encourage people to report the experience on
bitpim-user, but I think without too much success.

			Steve

[Bitpim-devel] Troubles with importing csv's (0.7 test)

[Somerlot, C. <CSo...@Br...>]

I get the following error when I try to import from a csv generated in Palm
Desktop, and I get a similar one with a csv from Outlook. 

An unexpected exception has occurred.
Please see the help for details on what to do.

Traceback (most recent call last):
  File "gui.pyo", line 653, in OnFileImport
  File "importexport.pyo", line 517, in OnImportCSVPhoneBook
  File "importexport.pyo", line 365, in GetFormattedData
Exception: Internal conversion failed to complete on ['', 'Brud', '',
'Tibbits', '', 'United Computer Capital Corp.', '', '', '5823 Widewaters
Parkway', '', '', 'E. Syracuse', 'NY', '13057', 'United States of America',
'', '', '', '', '0', 'Unfiled']
Still to do: {'Category': ['Unfiled'], 'Private': '0'}

Variables by last 6 frames, innermost last

Frame run in gui.pyo at line 332
           args =  (['C:\\Program Files\\BitPim\\bitpim.exe'],)
              m =  <gui.MainApp instance; proxy of C++ wxPyApp instance at
_9dc

Frame MainLoop in wxPython\wx.pyo at line 1974
           self =  <gui.MainApp instance; proxy of C++ wxPyApp instance at
_9dc

Frame MainLoop in wxPython\wx.pyo at line 92
        _kwargs =  {}
           self =  <gui.MainApp instance; proxy of C++ wxPyApp instance at
_9dc
          _args =  ()

Frame OnFileImport in gui.pyo at line 653
           path =  'C:\\Documents and Settings\\csomerlot\\My
Documents\\bitpim
           self =  <gui.MainWindow instance; proxy of C++ wxFrame instance
at _
            dlg =  wxPython wrapper for DELETED wxFileDialog object! (The
C++ o
              _ =  <wxPython.events.wxCommandEventPtr instance; proxy of C++
wx

Frame OnImportCSVPhoneBook in importexport.pyo at line 517
            dlg =  <importexport.ImportCSVDialog instance; proxy of C++
wxDialo
      phonebook =  <phonebook.PhoneWidget instance; proxy of C++ wxPanel
instan
           data =  None
         parent =  <gui.MainWindow instance; proxy of C++ wxFrame instance
at _
           path =  'C:\\Documents and Settings\\csomerlot\\My
Documents\\bitpim

Frame GetFormattedData in importexport.pyo at line 365
         prefix =  'Business'
        numbers =  [{'type': 'home', 'number': 'United Computer Capital
Corp.'}
           addr =  {'company': 'Tibbits', 'type': 'business'}
            val =  'United Computer Capital Corp.'
            res =  {0: {'numbers': [{'type': 'home', 'number': 'United
Computer
           self =  <importexport.ImportCSVDialog instance; proxy of C++
wxDialo
          field =  'Nickname'
            rec =  {'Category': ['Unfiled'], 'Private': '0'}
           type =  'business'
            key =  'Business Web Page'
         emails =  [{'email': '5823 Widewaters Parkway'}]
         shortk =  'Country/Region'
          count =  0
              c =  'Category'
              e =  '5823 Widewaters Parkway'
           name =  {'first': 'Brud'}
         fields =  ['Business Street', 'Business City', 'Business Postal
Code',
              k =  'Business Country/Region'
              n =  20
         record =  ['', 'Brud', '', 'Tibbits', '', 'United Computer Capital
Cor
           urls =  []
          entry =  {'numbers': [{'type': 'home', 'number': 'United Computer
Cap

Re: [Bitpim-devel] Media plans

[Steven P. <n9...@n9...>]

On Jan 7, 2004, at 3:11 AM, Roger Binns wrote:
> Please can you verify if my latest update to wallpaper.py works on Mac.

  Yes, it appears to work fine. If I have more images than will fit 
across the row(s) on the display and I resize the window to allow room 
for an additional row, the items will drop down to take advantage of 
it. So, despite the best efforts of the documentation to prove 
otherwise, it works. :-)

-. ----. -.-- - -.--
Steve Palm - n9...@n9...
-. ----. -.-- - -.--

[Bitpim-devel] Media plans

[Roger B. <ro...@ro...>]

Steven,

Please can you verify if my latest update to wallpaper.py works on Mac.
Basically while you have the wallpaper pane visible, you should be able
to resize the window and the items should automatically relayout as you
resize.

If they do, then all is well.  (According to the doc the auto relayout
should only be working on Windows, but it also works on Linux and the
wx doc is never too accurate anyway).

I have attached a photoshop of how I intend to change the wallpaper and
ringtone views.  (In ringtone view, the icons on the top will be different
for .mid, .qcp etc).

Any comments from anyone?

  And a small history lesson for anyone who cares.  The top left picture
  is from Sigiriya in Sri Lanka.  An absolutely amazing place to be.

  http://www.saadhu.com/sigiriya/
  http://sigiriya.org/gallery.htm

Roger

Re: [Bitpim-devel] Another little project

[Roger B. <ro...@ro...>]

>   Oh, I know all about this, and being my first Python code, I have NO
> DOUBT I'll wonder what I was thinking...

The very first Python code I wrote was a script I converted from TCL.
TCL doesn't really have objects, so it was this massive mess of
pseudo object oriented procedural code using two different languages
"normal" way of doing things, coupled with not really knowing what
is "normal" in Python.  You will be pleased to know the project was
not BitPim :-)

You might find the O'Reilly Python Cookbook quite useful.  It is
also available online at 

  http://aspn.activestate.com/ASPN/Cookbook/Python/

The file c.bat runs the all checkers and documentation generators.
It is quite a feat given the primitiveness of NT command scripting.
Unfortunately pychecker generates huge numbers of false positives.
wxPython 2.5 should remove a large number of them.

Roger

Re: [Bitpim-devel] Another little project

[Steven P. <n9...@n9...>]

On Jan 5, 2004, at 6:25 PM, Roger Binns wrote:
>>  I store the ID code as the original hex string,
>
> That is a really bad idea!  What is the difference between the
> following:

  For informational purposes only, it is not used for any 
calculations/etc... Sorry if that wasn't clear. For actual indexing of 
the values in the internal lists used to represent the objects, it is 
using pure integers. I suppose there really isn't much value to having 
this form of the ID stored, so it can go away and save a bit of memory. 
I'll make it so.

>>   Hey, I got one right! :-)   LoL
>
> Wait for a year, and then look at the code you wrote.  I always
> get embarrassed by my old code.  But hey, it even happens to Linus :-)

  Oh, I know all about this, and being my first Python code, I have NO 
DOUBT I'll wonder what I was thinking...

> Other than the keys you use should be integers throughout, epydoc 
> reported this:
>
> =======================================================
> C:\projects\bitpim\usb_ids.py
> In usb_ids.VendorList docstring (line 190):
> -------------------------------------------------------
>  L192: Error: Improper paragraph indentation.
>
> pychecker is happy.

  I'll have to read up on those checkers, I don't know anything about 
either one. ;-)

  If you find anything else that seems wrong or needs changing, let me 
know or fix it yourself depending on your mood at the time. :-)

-. ----. -.-- - -.--
Steve Palm - n9...@n9...
-. ----. -.-- - -.--

Re: [Bitpim-devel] Another little project

[Roger B. <ro...@ro...>]

>  I store the ID code as the original hex string, 

That is a really bad idea!  What is the difference between the
following:

  005ac
  5ac
  5Ac
  05aC

It will use less memory and be quicker to access if the internals
use pure integers!

>   Hey, I got one right! :-)   LoL

Wait for a year, and then look at the code you wrote.  I always
get embarrassed by my old code.  But hey, it even happens to Linus :-)

  http://lkml.org/lkml/2003/12/22/137

>   I suppose an alternate approach would be to always consider a line for
> it's matching as as a new vendor or new class line, and just interpret
> each subline according to the last major entry type you saw... yeah,
> that's it... ;-) Then we don't care about blank lines or comments.
> This is now implemented and sees to work properly.

The usual way of implementing this sort of thing is a state machine
which is what it seems like you have done.  The error cases and
some of the transitions get really tricky :-)

>   Okay, I will do this and also just expand on how a line is handled and
> be more rigorous about end-of-line trimming, removing all \n and \r
> characters at the end of the line before doing a pattern match on it.

That will work.

>   I thought of that, and thought you would have a "internet" database
> object and "bitpim" database object. If you fail to find it in the
> internet db you would consult the bitpim object.

The search actually needs to be the other way.  For example the Internet
database has things like "Prolific 2303 USB serial bridge" when we
want to display "FutureDial USB to serial cable for LGVX1/VX10/VX4400 (Prolific PL2303)"

>   Yes, but I like the (), as it helps me focus. LOL

I always prefer less code and punctuation, except when there is ambiguity.

>   Any other suggestions for the module, or is it pretty much OK now?  :-)

Other than the keys you use should be integers throughout, epydoc reported this:

=======================================================
C:\projects\bitpim\usb_ids.py
In usb_ids.VendorList docstring (line 190):
-------------------------------------------------------
 L192: Error: Improper paragraph indentation.

pychecker is happy.  I'll get around to hooking it into the browser at some
point.  A one line change also results in modems being listed on Windows
in comscan.  Unfortunately more code will be needed since it will currently
consider the modem interface valid for the 4400/6000 which it certainly isn't.

Roger