Menu

#15 Significant refactoring needed so that external contributors can contribute

open
nobody
bug (4)
2022-11-08
2022-10-20
Anonymous
No

Originally created by: danias

Subject of the issue

Significant refactoring needed so that external contributors can contribute

Discussion

  • Anonymous

    Anonymous - 2022-10-27

    Originally posted by: ellik95

    • TConstantVariable is used in domain (aggregates, entities, VOs). This must be replaced by TConstDeclaration.
    • Move if/else wrapping on domain evaluations to AST typescript model
    • Fix rule declaration that is implemented in a hacky way
    • Refactor domainCreateEntityMethod with domainCreate method which is similar (only the constructor changes)
    • Make class types work for multiple ones (from AST to target)
     
  • Anonymous

    Anonymous - 2022-11-07

    Originally posted by: Varagos

    [#150] Research whether we should create different types for each element (DTO, struct, Props etc..) in parser, or whether this should be done in the semantic analysis step (intermediate model validation), while keeping one type in the parser.

    If a validation step is introduced, the model types should be more specific, for example create of entity will expecter a props type, and not a BitloopsPrimaryType, so we will avoid all these redundant type checks

      if (BitloopsPrimTypeIdentifiers.isArrayPrimType(propsName)) {
        throw new Error('Array is not supported as entity props type');
      }
    
     
  • Anonymous

    Anonymous - 2022-11-08

    Originally posted by: sardounis

    File dependencies do not have clear API and they are used in multiple places

     
  • Anonymous

    Anonymous - 2022-11-08

    Originally posted by: sardounis

    Create specific classes for:

    • Navigating in the model
    • Building the model
    • Identifying the specific tree branch or leaf
     
  • Anonymous

    Anonymous - 2022-11-08

    Originally posted by: sardounis

    add tests for dependencies (toTarget)

     

Log in to post a comment.