Menu

#232 With Perl v5.14.2, use of qw(...) as parentheses is deprecated in bs_evgen.pm and DisplayCFG.pm

feature_request
closed
nobody
Perl-5.14 (1)
5
2017-06-06
2013-08-24
No

With Perl v5.14.2, use of qw(...) as parentheses is deprecated in:
bin/Statusmon/bs_evgen.pm: line 438
bin/Statusmon/DisplayCFG.pm: line 383

--- DisplayCFG.pm 2013-08-24 08:07:12.097833193 -0400
+++ DisplayCFG.pm 2013-08-24 08:08:13.305834460 -0400
@@ -380,7 +380,8 @@
"name" => $table
} );
$tab{"group"} = $table;
- foreach my $arg qw( refto itemref sort select select_names column_wrap items ) {
+ #foreach my $arg qw( refto itemref sort select select_names column_wrap items ) {
+ foreach my $arg (qw( refto itemref sort select select_names column_wrap items )) {
$tab{$arg} = $args{$arg} if( $args{$arg} );
}
$tab{"type"} = "table";

--- bs_evgen.pm 2013-08-24 08:07:12.097833193 -0400
+++ bs_evgen.pm 2013-08-24 08:07:45.129833876 -0400
@@ -435,7 +435,8 @@
elsif( $event->{"cmd"} eq "remove" ) {
my $host = $event->{"host"};
my $check = $event->{"check"};
- foreach my $queuename qw( alarms new_alarms old_alarms ) {
+ #foreach my $queuename qw( alarms new_alarms old_alarms ) {
+ foreach my $queuename (qw( alarms new_alarms old_alarms )) {
my $queue = $self->{$queuename};
for( my $i=$#$queue; $i>=0; $i-- ) {
my $alarm = $queue->[$i];

Discussion

  • Devon Hubner

    Devon Hubner - 2013-08-24

    --- vmstat.pm 2013-08-24 08:37:59.185871420 -0400
    +++ vmstat.pm 2013-08-24 08:30:02.657861558 -0400
    @@ -33,7 +33,8 @@
    $info0->{"$head"} = $value;
    }
    $duration = ($duration>0)?$duration:1;
    - foreach my $head qw( si so bi bo in cs ) {
    + #foreach my $head qw( si so bi bo in cs ) {
    + foreach my $head (qw( si so bi bo in cs )) {
    $info0->{"$head"} /= $duration;
    }
    return $info;

     
  • Thomas Aeby

    Thomas Aeby - 2013-08-24

    fixed in CVS Head. Statusmon::Display was also affected.

    Thanks for reporting!

     
  • Thomas Aeby

    Thomas Aeby - 2017-06-06
    • status: open --> closed
     

Log in to post a comment.