[Bigdata-commit] SF.net SVN: bigdata:[8019] branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/ com/bigdata/bop/solutions/MemoryGroupByOp.java

[<tho...@us...>]

Revision: 8019
          http://sourceforge.net/p/bigdata/code/8019
Author:   thompsonbry
Date:     2014-03-26 17:26:14 +0000 (Wed, 26 Mar 2014)
Log Message:
-----------
minor changes (javadoc edit, private method, final attribute).

Modified Paths:
--------------
    branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/solutions/MemoryGroupByOp.java

Modified: branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/solutions/MemoryGroupByOp.java
===================================================================
--- branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/solutions/MemoryGroupByOp.java	2014-03-26 16:13:38 UTC (rev 8018)
+++ branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/solutions/MemoryGroupByOp.java	2014-03-26 17:26:14 UTC (rev 8019)
@@ -515,7 +515,7 @@
          *         for the group was dropped (type error or violated HAVING
          *         constraint).
          */
-        public IBindingSet aggregate(final Iterable<IBindingSet> solutions) {
+        private IBindingSet aggregate(final Iterable<IBindingSet> solutions) {
 
             if (!solutions.iterator().hasNext()) {
                 // Drop empty group.
@@ -704,7 +704,7 @@
      *            will be bound.
      * @param selectDependency
      *            When <code>true</code>, some aggregates bind variables which
-     *            are relied on both other aggregates. In this case, this method
+     *            are relied on by other aggregates. In this case, this method
      *            must ensure that those bindings become visible.
      * @param aggregates
      *            The binding set on which the results are being bound (by the
@@ -782,7 +782,8 @@
                 expr.reset();
                 
                 for (IBindingSet bset : solutions) {
-                    Object constants[]=new Object[expr.arity()];
+                    
+                    final Object constants[] = new Object[expr.arity()];
 
                     for (int i=0;i<expr.arity();i++){
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.