[Bigdata-commit] SF.net SVN: bigdata:[7763] branches/BIGDATA_RELEASE_1_3_0/bigdata-rdf/src/ java/com/bigdata/rdf/sparql/ast/eval/AST2BOpRTO.java

[<tho...@us...>]

Revision: 7763
          http://bigdata.svn.sourceforge.net/bigdata/?rev=7763&view=rev
Author:   thompsonbry
Date:     2014-01-10 21:51:38 +0000 (Fri, 10 Jan 2014)
Log Message:
-----------
javadoc

Modified Paths:
--------------
    branches/BIGDATA_RELEASE_1_3_0/bigdata-rdf/src/java/com/bigdata/rdf/sparql/ast/eval/AST2BOpRTO.java

Modified: branches/BIGDATA_RELEASE_1_3_0/bigdata-rdf/src/java/com/bigdata/rdf/sparql/ast/eval/AST2BOpRTO.java
===================================================================
--- branches/BIGDATA_RELEASE_1_3_0/bigdata-rdf/src/java/com/bigdata/rdf/sparql/ast/eval/AST2BOpRTO.java	2014-01-10 21:48:09 UTC (rev 7762)
+++ branches/BIGDATA_RELEASE_1_3_0/bigdata-rdf/src/java/com/bigdata/rdf/sparql/ast/eval/AST2BOpRTO.java	2014-01-10 21:51:38 UTC (rev 7763)
@@ -61,6 +61,7 @@
 import com.bigdata.bop.Var;
 import com.bigdata.bop.ap.Predicate;
 import com.bigdata.bop.ap.SampleIndex.SampleType;
+import com.bigdata.bop.bset.ConditionalRoutingOp;
 import com.bigdata.bop.engine.IRunningQuery;
 import com.bigdata.bop.engine.QueryEngine;
 import com.bigdata.bop.join.JoinAnnotations;
@@ -218,6 +219,15 @@
      * estimated cardinality of the join since we can not compute the join hit
      * ratio without knowing the #of solutions in required to produce a given
      * #of solutions out.
+     * 
+     * FIXME Make this <code>true</code>. There is a known problem where a
+     * {@link ConditionalRoutingOp} can cause out of order evaluation if some
+     * solutions flow along the default sink and some along the alt sink. I
+     * think that the fix for this is to make the materialization step
+     * non-conditional when performing cutoff evaluation of the join. I need to
+     * run this past MikeP, so this allows out-of-order evaluation for the
+     * moment. See BSBM Q5 for a query that currently fails if out of order
+     * evaluation is disallowed.
      */
     static final private boolean failOutOfOrderEvaluation = false;
     

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.