[Bigdata-commit] SF.net SVN: bigdata:[7742] branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/ com/bigdata/bop/joinGraph/rto

[<tho...@us...>]

Revision: 7742
          http://bigdata.svn.sourceforge.net/bigdata/?rev=7742&view=rev
Author:   thompsonbry
Date:     2014-01-07 18:24:40 +0000 (Tue, 07 Jan 2014)
Log Message:
-----------
@Overrides and javadoc.

Modified Paths:
--------------
    branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/JGraph.java
    branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/JoinGraph.java
    branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/Vertex.java

Modified: branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/JGraph.java
===================================================================
--- branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/JGraph.java	2014-01-07 11:05:13 UTC (rev 7741)
+++ branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/JGraph.java	2014-01-07 18:24:40 UTC (rev 7742)
@@ -208,6 +208,10 @@
  *       will be no paths identified by the optimizer and the final path length
  *       becomes zero.
  * 
+ * @see <a href="https://sourceforge.net/apps/trac/bigdata/ticket/64">Runtime
+ *      Query Optimization</a>
+ * @see <a href="https://sourceforge.net/apps/trac/bigdata/ticket/258">Integrate
+ *      RTO into SAIL</a>
  * @see <a
  *      href="http://www-db.informatik.uni-tuebingen.de/files/research/pathfinder/publications/rox-demo.pdf">
  *      ROX </a>
@@ -286,7 +290,7 @@
 	 * @todo unit test when the join graph has a single vertex.
 	 */
     public JGraph(final IPredicate<?>[] v, final IConstraint[] constraints,
-            final SampleType sampleType) {
+                final SampleType sampleType) {
 
         if (v == null)
             throw new IllegalArgumentException();

Modified: branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/JoinGraph.java
===================================================================
--- branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/JoinGraph.java	2014-01-07 11:05:13 UTC (rev 7741)
+++ branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/JoinGraph.java	2014-01-07 18:24:40 UTC (rev 7742)
@@ -50,6 +50,7 @@
 import com.bigdata.bop.ap.SampleIndex.SampleType;
 import com.bigdata.bop.controller.AbstractSubqueryOp;
 import com.bigdata.bop.engine.AbstractRunningQuery;
+import com.bigdata.bop.engine.BOpStats;
 import com.bigdata.bop.engine.IRunningQuery;
 import com.bigdata.bop.engine.QueryEngine;
 import com.bigdata.rdf.sparql.ast.IJoinNode;
@@ -206,6 +207,9 @@
      * 
      * @author <a href="mailto:tho...@us...">Bryan
      *         Thompson</a>
+     * 
+     *         TODO This could also be put on a {@link BOpStats} interface,
+     *         which is the other way for accessing shared state.
      */
     public interface Attributes {
 

Modified: branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/Vertex.java
===================================================================
--- branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/Vertex.java	2014-01-07 11:05:13 UTC (rev 7741)
+++ branches/BIGDATA_RELEASE_1_3_0/bigdata/src/java/com/bigdata/bop/joinGraph/rto/Vertex.java	2014-01-07 18:24:40 UTC (rev 7742)
@@ -83,6 +83,7 @@
 
     }
 
+    @Override
     public String toString() {
 
         return "Vertex{pred=" + pred + ",sample=" + sample + "}";
@@ -92,6 +93,7 @@
     /**
      * Equals is based on a reference test.
      */
+    @Override
     public boolean equals(Object o) {
         return this == o;
     }
@@ -100,6 +102,7 @@
      * The hash code is just the {@link BOp.Annotations#BOP_ID} of the
      * associated {@link IPredicate}.
      */
+    @Override
     public int hashCode() {
         return pred.getId();
     }

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.