[Bigdata-developers] MIN and MAX aggregates fixed: trac 736 (with question?)

[Jeremy J C. <jj...@sy...>]

Please glance at this code (from MIN.java or MAX.java)

...

+           private static IVComparator comparator = new IVComparator();

…

 
-                /**
-                 * FIXME This needs to use the ordering define by ORDER_BY. The
-                 * CompareBOp imposes the ordering defined for the "<" operator
-                 * which is less robust and will throw a type exception if you
-                 * attempt to compare unlike Values.
-                 *
-                 * @see https://sourceforge.net/apps/trac/bigdata/ticket/300#comment:5
-                 */
-                if (CompareBOp.compare(iv, min, CompareOp.LT)) {
+                if (comparator.compare(iv, min)<0) {
 
                     min = iv;
 
                 }



It seems to work, but I read something about requiring materialization which I did not understand and chose to ignore - was that a mistake?

Jeremy J Carroll
Principal Architect
Syapse, Inc.