Re: [Bigdata-developers] use of -DtestClass=com.bigdata.rdf.sail.TestBigdataSailWithQuads and QuadsTestCase

[Bryan T. <br...@sy...>]

Yes, seems reasonable.

The pattern exists because we support various persistence stores (RWStore, WORMStore, MemStore, etc) and various RDF DB semantics (triples, triples with provenance, quads). So, the pattern is necessary, but for the QuadsTestCase we always specify a specific value, so it could be defaulted to that constant.

I would just verify that the derived classes all run in "quads mode". Historically, the QuadsTestCase was put together by Mike to help people write unit tests at the SAIL layer.  Today, we tend to prefer tests written using RDF data, SPARQL query or update, and the expected results all in files.  Maybe we will eventually use manifests.

But, to the point, I think that some of the QuadsTestCase derived tests might not actually be for quads.  Check the specific subclasses to be certain.

Bryan

From: Mike Personick <mi...@sy...<mailto:mi...@sy...>>
Date: Wednesday, October 2, 2013 8:27 AM
To: Jeremy Carroll <jj...@sy...<mailto:jj...@sy...>>, "Big...@li...<mailto:Big...@li...>" <Big...@li...<mailto:Big...@li...>>
Subject: Re: [Bigdata-developers] use of -DtestClass=com.bigdata.rdf.sail.TestBigdataSailWithQuads and QuadsTestCase

It seems reasonable to me.   Bryan?

From: Jeremy J Carroll <jj...@sy...<mailto:jj...@sy...>>
Date: Tuesday, October 1, 2013 4:19 PM
To: "Big...@li...<mailto:Big...@li...>" <Big...@li...<mailto:Big...@li...>>
Subject: [Bigdata-developers] use of -DtestClass=com.bigdata.rdf.sail.TestBigdataSailWithQuads and QuadsTestCase


A question/suggestion, primarily for Mike.

In the trac737 tests, in r7424, I subclassed from QuadsTestCase, which says:
   Specify
 * <code>-DtestClass=com.bigdata.rdf.sail.TestBigdataSailWithQuads</code> to
 * run this test suite.



Because it is ever so slightly irritating to set the environment flag, I decided to hard code a default in my subclass with:


    public AbstractBigdataSailTestCase getOurDelegate() {

        if (getDelegate() == null) {

            String testClass = System.getProperty("testClass");
            if (testClass != null) {
            return super.getOurDelegate();

            }
            setDelegate(new com.bigdata.rdf.sail.TestBigdataSailWithQuads());
        }
        return (AbstractBigdataSailTestCase) super.getDelegate();
    }


I am wondering whether this method would be an improvement to the QuadsTestCase class, and should be pulled up?


Jeremy J Carroll
Principal Architect
Syapse, Inc.