Re: [Bigdata-developers] trac746 - ArbitraryLengthPathNode missing case in ASTComplexOptionalOptimizer

[Mike P. <mi...@sy...>]

The fix looks right to me.  An ALPNode is definitely a required join.
 


On 9/26/13 6:09 AM, "Jeremy J Carroll" <jj...@sy...> wrote:

>My reasoning was no more than it (naively) seemed quite like a Union to
>me, and the assertion failure was there to catch that the case had not
>been thought about.
>
>After the fix, the query does give the correct result on my dev system
>(and a load of data mentioned in an earlier bug report) - but the test
>case does not show that.
>
>Jeremy J Carroll
>Principal Architect
>Syapse, Inc.
>
>
>
>On Sep 25, 2013, at 6:15 PM, Bryan Thompson <br...@sy...> wrote:
>
>> Mike, can you comment on this? The issue appears to be the handling
>>logic for complex optionals.  That code predates the introduction of
>>property paths.  The question is whether a property path needs to be
>>treated as a required join and moved into the named sub-query. This
>>sounds reasonable in principle to me, but I am not that close to the
>>property path implementation. Bryan
>> 
>>> On Sep 25, 2013, at 8:58 PM, "Jeremy J Carroll" <jj...@sy...> wrote:
>>> 
>>> 
>>> I hit a show stopper this week in my work, and I think I have fixed it
>>>- a one liner:
>>> 
>>> I currently have the test case and the fix in my copy of the repo, and
>>>thought I should get a go ahead before committing to SVN
>>> 
>>> The defect report is:
>>> https://sourceforge.net/apps/trac/bigdata/ticket/746
>>> 
>>> The test case (which is somewhat deficient - it exercised the fault
>>>but did not suggest correct behavior other than not to die)
>>> 
>>> 
>>>https://github.com/jeremycarroll/bigdata/commit/7fa5ae51acc5f49b085f0dd3
>>>cc6654f87802b2c7
>>> 
>>> The fix:
>>> 
>>>https://github.com/jeremycarroll/bigdata/commit/c4702b76f670d7bc327ed6eb
>>>49dec139259cbc72
>>> 
>>> If someone can look at that one-line fix and OK it, I will commit to
>>>SVN
>>> 
>>> 
>>> Jeremy J Carroll
>>> Principal Architect
>>> Syapse, Inc.
>>> 
>>> 
>>> 
>>> 
>>> 
>>>------------------------------------------------------------------------
>>>------
>>> October Webinars: Code for Performance
>>> Free Intel webinars can help you accelerate application performance.
>>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the
>>>most from 
>>> the latest Intel processors and coprocessors. See abstracts and
>>>register >
>>> 
>>>http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clk
>>>trk
>>> _______________________________________________
>>> Bigdata-developers mailing list
>>> Big...@li...
>>> https://lists.sourceforge.net/lists/listinfo/bigdata-developers
>> 
>> 
>>-------------------------------------------------------------------------
>>-----
>> October Webinars: Code for Performance
>> Free Intel webinars can help you accelerate application performance.
>> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the
>>most from 
>> the latest Intel processors and coprocessors. See abstracts and
>>register >
>> 
>>http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clkt
>>rk
>> _______________________________________________
>> Bigdata-developers mailing list
>> Big...@li...
>> https://lists.sourceforge.net/lists/listinfo/bigdata-developers
>