|
From: Bryan T. <br...@sy...> - 2010-09-03 16:05:26
|
Brian,
So it might be this method (below) in NicUtil which is dragging in the jini dependency? While I do not disagree with your comments about the usefulness and utility of jini in non-distributed situations, would it be possible to move this method into another class so that the bigdata "core" packages do not have a jini dependency?
Thanks,
Bryan
/**
* Three-argument version of <code>getInetAddress</code> that retrieves
* the desired interface name from the given <code>Configuration</code>
* parameter.
*/
public static InetAddress getInetAddress(Configuration config,
String componentName,
String nicNameEntry)
{
String nicName = "NoNetworkInterfaceName";
try {
nicName = (String)Config.getNonNullEntry(config,
componentName,
nicNameEntry,
String.class,
"eth0");
} catch(ConfigurationException e) {
jiniConfigLogger.log(WARNING, e
+" - [componentName="+componentName
+", nicNameEntry="+nicNameEntry+"]");
utilLogger.log(Level.WARN, e
+" - [componentName="+componentName
+", nicNameEntry="+nicNameEntry+"]");
e.printStackTrace();
return null;
}
return ( getInetAddress(nicName, 0, null, false) );
}
________________________________
From: Brian Murphy [mailto:btm...@gm...]
Sent: Friday, September 03, 2010 11:53 AM
To: big...@li...
Subject: Re: [Bigdata-developers] [Bigdata-commit] SF.net SVN: bigdata:[3499] trunk/build.xml
On Fri, Sep 3, 2010 at 8:04 AM, Bryan Thompson <br...@sy...<mailto:br...@sy...>> wrote:
I was not aware that they were deprecated. Are they being used anywhere else?
Yes. It looks like they're referenced in a couple of places;
specifically the ServerStarter.config file under bigdata-rdf
and the eclipse-specific .classpath file.
Can we just remove them from the set of jars bundled with bigdata, substituting the jars which you identify below?
Sure.
Also, see [1] which is an issue to remove the jini/river dependency for the standalone database deployment.
Even if you're not executing scaleout services, the jini
platform and utility jars are useful to include; and actually
may be required in some cases. For example, even in
standalone, I believe configuration currently references
the jini configuration classes. Additionally, NicUtil references
some of the jini utility and/or configuration classes.
That said, there is no need to include any of the jini
service-specific jar files when you're not running those
services; that is, reggie.jar, etc.
I hope this helps,
BrianM
|