|
From: Bryan T. <br...@sy...> - 2010-06-29 13:56:48
|
Brian,
The LocalDataService was originally designed to allow a single non-sharded data service using a ConcurrencyManager with a client/server separation. There are several unit tests which fail for this class. Also, the rule execution logic is currently more complicated than it needs to be in order to support this edge case -- where all of the indices are known to be co-located on a single data service. I plan to scrap the LocalDataService when we do the rule refactor (2nd part of July) so we can simplify the rule execution logic.
The EmbeddedFederation is a within JVM federation that uses some special logic for how it locates its files for the various backing services. The EmbeddedFederation does not use jini or zookeeper and does not do RMI. This class is useful at times when debugging code written against the IBigdataFederation interface since all the code executes in the same process and you can put a debugger on it. It also made it easy to write and run unit tests against a federation without starting and stopping jini and zookeeper processes.
Based on the work that you have been doing, it is now much easier to start/stop the necessary processes and to run test suites against a JiniFederation. Therefore, I propose that we move the EmbeddedFederation class for now into src/test and phase it out as we migrate unit tests to execute directly against a JiniFederation.
I am not sure which test_U1 and test_U10 unit tests you mean. A search for test_U10 suggests that this is probably in TestTripleStoreLoadRateWithEmbeddedFederation? If so, then all of the TestTripleStoreLoadRateXXX classes are slated for removal and I can remove them now from the trunk.
Thanks,
Bryan
________________________________
From: Brian Murphy [mailto:btm...@gm...]
Sent: Tuesday, June 29, 2010 8:32 AM
To: big...@li...
Subject: [Bigdata-developers] rdf.store tests
I've been looking at the tests in com.bigdata.rdf.store
recently and I was hoping someone on the list might be
able to clear up some confusion I've been having with a
couple of the tests from that suite:
TestScaleOutTripleStoreWithLocalDataServiceFederation
and
TestScaleOutTripleStoreWithEmbeddedFederation
When trying to run those tests (using either ant or eclipse),
some issues were encountered; for example,
In TestScaleOutTripleStoreWithLocalDataServiceFederation,
the directory from which data is loaded is, "../rdf-data/lehigh/U1";
which doesn't seem to exist.
If the directory is changed to "bigdata-rdf/src/resources/data/lehigh/U1",
which does exist, then the test 'test_U1' hangs (never completes, even
when run over night).
With respect to the other test (TestScaleOutTripleStoreWithEmbeddedFederation),
unlike the first test, that test suite does use the correct/existing directory
("bigdata-rdf/src/resources/data/lehigh/U1"). Additionally, that
suite's version of 'test_U1' actually completes and passes. But
the suites next test ('test_U10') never completes.
Finally, in com.bigdata.rdf.store.TestAll, although the two tests
above appear to have been executed at some point in the past
by TestAll, the execution of those tests are now commented out.
Can anyone shed some light on those two tests? Are they
commented out rather than removed because there's an intent
or desire to fix them and re-instate their execution in the CI?
Thanks,
BrianM
|