[Bigdata-developers] [bigdata®] #72: Testing - Make changes to allow all tests of TestServiceStarter to pass when run using both ant & eclipse

[b. <no...@so...>]

#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
 Reporter:  btmurphy            |       Owner:  btmurphy
     Type:  defect              |      Status:  new     
 Priority:  major               |   Milestone:          
Component:  Bigdata Federation  |     Version:          
 Keywords:                      |  
--------------------------------+-------------------------------------------
 In comment 34 of Trac issue #53, indicates that the tests
 specified by com.bigdata.jini.start.TestServiceStarter do
 not all pass when run using either ant or eclipse.

 As indicated in that comment, when run using eclipse, the
 tests fail because a security policy file is not set on
 the VM in which the tests run.

 Additionally, because of changes made as part of changeset 2614,
 AbstractFedZooTestCase now overrides the groups to join for the
 TransactionServer that is started as part of the test. These
 changes have resulted in test failures when using the ant junit
 task; because the TransactionServer is not discovered, because
 the member groups of the lookup service that is started by ant
 is not the same as the groups the TransactionServer is configured
 to join.

 Finally, besides the above issues, it appears that the test
 TestServiceStarter.test_startServer will fail in a number of
 ways related to how the Zookeeper client and server are
 handled in that test. For example,

 1. It appears that 2 child znodes are created, a "physical services"
 znode, and a "master election" znode. But when the test attempts
 to verify that the physicalServices znode was registered with
 the Zookeeper server, it the test will fail because the test
 asserts that there is only 1 child znode, when there is actually
 2 children.

 2. When the "physical services" znode is created, an empty byte
 array is input for the data parameter; which will cause the test
 to fail with a RuntimeException when an attempt is made to
 validate the serviceUUID by deserializing the data element
 associated with that znode.

 3. At the end of test_startServer, the test waits 20 seconds
 for the physical services znode to be removed. But it appears
 that the test will always fail because that znode is not removed
 until the AbstractZooFedTestCase.tearDown method is called (which
 calls ProcessHelper.kill & JiniFederation.shutdownNow); which
 is not invoked until after the wait for znode removal has
 timed out and the test has declared failure.

 There are a number of changes that can be made to address the
 issues described above.

-- 
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.