Menu
▾
▴
bigdata-developers
|
From: b. <no...@so...> - 2010-04-21 16:48:15
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
In comment 34 of Trac issue #53, indicates that the tests
specified by com.bigdata.jini.start.TestServiceStarter do
not all pass when run using either ant or eclipse.
As indicated in that comment, when run using eclipse, the
tests fail because a security policy file is not set on
the VM in which the tests run.
Additionally, because of changes made as part of changeset 2614,
AbstractFedZooTestCase now overrides the groups to join for the
TransactionServer that is started as part of the test. These
changes have resulted in test failures when using the ant junit
task; because the TransactionServer is not discovered, because
the member groups of the lookup service that is started by ant
is not the same as the groups the TransactionServer is configured
to join.
Finally, besides the above issues, it appears that the test
TestServiceStarter.test_startServer will fail in a number of
ways related to how the Zookeeper client and server are
handled in that test. For example,
1. It appears that 2 child znodes are created, a "physical services"
znode, and a "master election" znode. But when the test attempts
to verify that the physicalServices znode was registered with
the Zookeeper server, it the test will fail because the test
asserts that there is only 1 child znode, when there is actually
2 children.
2. When the "physical services" znode is created, an empty byte
array is input for the data parameter; which will cause the test
to fail with a RuntimeException when an attempt is made to
validate the serviceUUID by deserializing the data element
associated with that znode.
3. At the end of test_startServer, the test waits 20 seconds
for the physical services znode to be removed. But it appears
that the test will always fail because that znode is not removed
until the AbstractZooFedTestCase.tearDown method is called (which
calls ProcessHelper.kill & JiniFederation.shutdownNow); which
is not invoked until after the wait for znode removal has
timed out and the test has declared failure.
There are a number of changes that can be made to address the
issues described above.
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-04-21 17:10:02
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
To set a policy file on the VM of a test being launched
by eclipse, do something like the following, (using
com.bigdata.jini.start.TestAll.java as an example):
1. In the Package Explorer of eclipse, double-click
"bigdata-jini/src/test"
2. Under "bigdata-jini/src/test", expand "com.bigdata.jini.start"
3. Right-click "TestAll.java"
4. Select "Properties" at the bottom of the drop-down menu
5. If not already selected, select "Run/Debug Settings"
(in the left hand window)
6. Select "TestAll" in the "Launch configurations" window
7. Click the button labeled "Edit..."
8. In the "Edit Configuration" window that appears, click on
the tab labeled "(x)= Arguments"
9. In the window labeled "VM arguments", enter the following:
-Djava.security.policy=src/resources/config/policy.all
10. Click "OK" in all windows
Note that I am not an eclipse user, and the above is what
worked for me. But I'm guessing that the eclipse experts
out there probably know a way for setting this system
property globally for all tests, rather than doing the
above on a test-by-test basis; which they should share
with us newbies.
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:1>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-04-21 17:27:33
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
To address the issue related to changeset 2614
and the overriding of the groups to join, rather
than overloading the fedname, a zrootname should
be added to com/bigdata/jini/start/testfed.config,
and the JiniClient groups should be augmented to
include both the fedname and the new zrootname.
Related to the above, references to 'fedname' in
com.bigdata.jini.start.AbstractFedZooTestCase.java
should be changed to zrootname.
Additionally, to address the ClassNotFoundException
issue (QuorumPeerMain) when launching TestServiceStarter
using ant, under the run-junit target of build.xml,
the java.class.path system property should be set to
the value of the run.class.path property.
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:2>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-04-21 17:49:26
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
To address the issues related to how the Zookeeper
client and server handled in TestServiceStarter, the
following changes are proposed for the
TestServiceStarter.test_startServer test:
1. Move the instantiation of the new serviceStarter
to occur before the creation of the "physical services"
znode.
2. Change the creation of the "physical services" znode
to take the serialized form of serviceStarter.UUID
instead of an empty byte array.
3. Change assertEquals(1, children.size()); to
assertEquals(2, children.size());
4. Prior to the call to ZNodeDeletedWatcher.awaitDelete,
call com.bigdata.zookeeper.ZooHelper.destroyZNodes with
a depth of 1. (Or simply remove the call to awaitDelete,
and let tearDown remove the znodes.)
5. In com.bigdata.jini.start.AbstractFedZooTestCase.setUp,
remove the try-catch block in which
zookeeper.create("/test", ... ) is called.
6. In com.bigdata.jini.start.config.JiniServiceConfiguration,
in the writeGroups and writeLocators methods, handle the
case where there are more than one element in the set,
by inserting a comma between each element that is written
to the output file.
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:3>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-04-21 18:18:48
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
To provide a convenient mechanism for externally
running a lookup service when running a test (such
as TestServiceStarter) under eclipse, as well as to
address changeset 2516, the following additions/deletions
are being proposed as part of the fix for this
trac issue:
1. Add the directory, src/resources/bin/config
2. Under src/resources/bin/config, add the following
config files: reggie.config, browser.config, zookeeper.config,
and serviceStarter.config
3. Under src/resources/config/jini/, delete the
following config files: serviceStarterAll.config,
serviceStarterOne.config, and zookeeper.config,
as well as, browser.config.tmp and reggie.config.tmp
4. Make the appropriate changes to build.xml to
accomodate the new config files (set new directory
properties, copy the config files to the staging
area, etc.)
5. Make the necessary changes to src/resources/bin/pstart
to use the new config files.
Doing the above should then allow one who wishes to
launch TestServiceStarter from eclipse to do something
like the following:
cmdWinA: cd <bigdata-dir>
cmdWinA: ./dist/bigdata/bin/pstart --mGroups=testFed reggie
cmdWinB: cd <bigdata-dir> [*** optional ***]
cmdWinB: ./dist/bigdata/bin/pstart --groups=testFed browser
[Note that reggie must be started with mGroups (groups
is optional for reggie), whereas the browser and other
services are started with groups.]
Once a lookup service has been started with member groups
equal to "testFed", TestServiceStarter tests can be
launched from eclipse.
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:4>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-04-21 19:05:16
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
The changes proposed in the comments above have been
checked in to the branch named 'dev-btm' (changeset 2663)
and should probably be reviewed before they're
merged to the trunk; which I'll do in a day or two.
The files changed are as follows:
M bigdata-jini/src/test/com/bigdata/jini/start/testfed.config
M bigdata-jini/src/test/com/bigdata/jini/start/TestServiceStarter.java
M bigdata-jini/src/test/com/bigdata/jini/start/AbstractFedZooTestCase.java
M bigdata-
jini/src/java/com/bigdata/jini/start/config/JiniServiceConfiguration.java
M src/resources/bin/pstart
M build.xml
A src/resources/bin/config
A src/resources/bin/config/reggie.config
A src/resources/bin/config/browser.config
A src/resources/bin/config/zookeeper.config
A src/resources/bin/config/serviceStarter.config
D src/resources/config/jini/serviceStarterAll.config
D src/resources/config/jini/reggie.config.tmp
D src/resources/config/jini/browser.config.tmp
D src/resources/config/jini/zookeeper.config
D src/resources/config/jini/serviceStarterOne.config
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:5>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-04-22 15:18:25
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
Made similar changes to allow the tests in com.bigdata.jini.start.config
to run and pass under either eclipse or ant. The changes proposed
have also been checked in to the 'dev-btm' branch (changeset 2669).
The files changed are as follows:
M bigdata-jini/src/test/com/bigdata/jini/start/config/testfed.config
M bigdata-
jini/src/test/com/bigdata/jini/start/config/TestServiceConfiguration.java
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:6>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-04-28 15:52:40
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
Made changes to the files listed below to allow one
to run the test TestJiniCoreServicesProcessHelper using
either ant or eclipse. That test now uses the Jini
ServiceStarter to start a lookup service and an httpd
class server, verifies that the lookup service was
started, and then shutdowns both the lookup service
and the class server. The changed and added files have
been checked in to the 'dev-btm' branch (changeset 2713).
M bigdata-
jini/src/test/com/bigdata/jini/start/TestJiniCoreServicesProcessHelper.java
M bigdata-jini/src/test/com/bigdata/jini/start/testjini.config
M bigdata-
jini/src/java/com/bigdata/jini/start/config/JiniCoreServicesConfiguration.java
M build.xml
A bigdata-jini/src/test/com/bigdata/jini/start/testReggie.config
A bigdata-jini/src/test/com/bigdata/jini/start/testStartJini.config
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:7>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-04-28 18:53:52
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
More changes to allow the use of either ant or eclipse
to run the tests; in particular, the tests under
com.bigdata.service.jini, which use the config file
src/resources/config/bigdataStandaloneTesting.config
(changeset 2716).
M bigdata-jini/src/test/com/bigdata/jini/start/testjini.config
M bigdata-jini/src/resources/config/bigdataStandaloneTesting.config
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:8>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-04-28 21:35:58
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
Changeset 2718 & 2720
M bigdata-jini/src/test/com/bigdata/zookeeper/testzoo.config
M bigdata-jini/src/resources/config/bigdataStandaloneTesting.config
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:9>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2010-05-02 16:28:23
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
--------------------------------+-------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: new
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Keywords: |
--------------------------------+-------------------------------------------
Comment(by btmurphy):
Changeset 2732 - merged changes from branch dev-btm --> trunk
M bigdata-
jini/src/java/com/bigdata/jini/start/config/JiniCoreServicesConfiguration.java
M bigdata-
jini/src/java/com/bigdata/jini/start/config/JiniServiceConfiguration.java
M bigdata-jini/src/resources/config/bigdataStandaloneTesting.config
M bigdata-jini/src/test/com/bigdata/jini/start/AbstractFedZooTestCase.java
M bigdata-
jini/src/test/com/bigdata/jini/start/TestJiniCoreServicesProcessHelper.java
M bigdata-jini/src/test/com/bigdata/jini/start/TestServiceStarter.java
M bigdata-
jini/src/test/com/bigdata/jini/start/config/TestServiceConfiguration.java
M bigdata-jini/src/test/com/bigdata/jini/start/config/testfed.config
M bigdata-jini/src/test/com/bigdata/jini/start/testfed.config
M bigdata-jini/src/test/com/bigdata/jini/start/testjini.config
M bigdata-jini/src/test/com/bigdata/zookeeper/testzoo.config
M build.xml
M src/resources/bin/pstart
A bigdata-jini/src/test/com/bigdata/jini/start/testReggie.config
A bigdata-jini/src/test/com/bigdata/jini/start/testStartJini.config
A src/resources/bin/config
A src/resources/bin/config/browser.config
A src/resources/bin/config/reggie.config
A src/resources/bin/config/serviceStarter.config
A src/resources/bin/config/zookeeper.config
D src/resources/config/jini/browser.config.tmp
D src/resources/config/jini/reggie.config.tmp
D src/resources/config/jini/serviceStarterAll.config
D src/resources/config/jini/serviceStarterOne.config
D src/resources/config/jini/zookeeper.config
The changes above should now allow one to run -- under
either eclipse or ant -- the tests located in the
following namespaces under bigdata-jini/src/test:
com.bigdata.jini
com.bigdata.jini.start
com.bigdata.jini.start.config
com.bigdata.service.jini
com.bigdata.service.jini.master
com.bigdata.zookeeper
Note that the test com.bigdata.zookeeper.TestHierachicalZNodeWatcher
does not pass consistently; which may be due to the fact that
zookeeper does not guarantee that all events will be seen, as
indicated in the javadoc of
com.bigdata.zookeeper.HierarchicalZNodeWatcher.
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:10>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
|
From: b. <no...@so...> - 2011-06-23 14:38:51
|
#72: Testing - Make changes to allow all tests of TestServiceStarter to pass
when run using both ant & eclipse
---------------------------------+------------------------------------------
Reporter: btmurphy | Owner: btmurphy
Type: defect | Status: closed
Priority: major | Milestone:
Component: Bigdata Federation | Version:
Resolution: fixed | Keywords:
---------------------------------+------------------------------------------
Changes (by thompsonbry):
* status: new => closed
* resolution: => fixed
Comment:
This has been resolved in [1].
[1] https://sourceforge.net/apps/trac/bigdata/ticket/297#comment:17
--
Ticket URL: <http://sourceforge.net/apps/trac/bigdata/ticket/72#comment:11>
bigdata® <http://www.bigdata.com/blog>
bigdata® is a scale-out storage and computing fabric supporting optional transactions, very high concurrency, and very high aggregate IO rates.
|
Thanks for helping keep SourceForge clean.
X