bigdata-commit

[Bigdata-commit] SF.net SVN: bigdata:[7681] branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src /java/com/bigdata/rdf/sail/webapp/InsertServlet.java

[<tho...@us...>]

Revision: 7681
          http://bigdata.svn.sourceforge.net/bigdata/?rev=7681&view=rev
Author:   thompsonbry
Date:     2013-12-19 14:58:34 +0000 (Thu, 19 Dec 2013)
Log Message:
-----------
Added a check for no Content-Type header to avoid an NPE.

Modified Paths:
--------------
    branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java

Modified: branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java
===================================================================
--- branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java	2013-12-18 21:47:44 UTC (rev 7680)
+++ branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java	2013-12-19 14:58:34 UTC (rev 7681)
@@ -140,7 +140,7 @@
         final String namespace = getNamespace(req);
 
         final String contentType = req.getContentType();
-
+        if(contentType==null) buildResponse(resp, HTTP_BADREQUEST, MIME_TEXT_PLAIN, "Content-Type not specified.");
         if (log.isInfoEnabled())
             log.info("Request body: " + contentType);
 

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bigdata-commit] SF.net SVN: bigdata:[8486] branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src /java/com/bigdata/rdf/sail/webapp/InsertServlet.java

[<tho...@us...>]

Revision: 8486
          http://sourceforge.net/p/bigdata/code/8486
Author:   thompsonbry
Date:     2014-06-16 16:23:25 +0000 (Mon, 16 Jun 2014)
Log Message:
-----------
Correctness: should set success:=true immediately after the commit.

Modified Paths:
--------------
    branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java

Modified: branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java
===================================================================
--- branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java	2014-06-16 16:22:55 UTC (rev 8485)
+++ branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java	2014-06-16 16:23:25 UTC (rev 8486)
@@ -315,12 +315,12 @@
                 // Commit the mutation.
                 conn.commit();
 
+                success = true;
+
                 final long elapsed = System.currentTimeMillis() - begin;
 
                 reportModifiedCount(nmodified.get(), elapsed);
 
-                success = true;
-
                 return (Void) null;
 
             } finally {

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bigdata-commit] SF.net SVN: bigdata:[8541] branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src /java/com/bigdata/rdf/sail/webapp/InsertServlet.java

[<tho...@us...>]

Revision: 8541
          http://sourceforge.net/p/bigdata/code/8541
Author:   thompsonbry
Date:     2014-07-13 12:25:31 +0000 (Sun, 13 Jul 2014)
Log Message:
-----------
Javadoc for "REST API INSERT" does not handle .gz ticket.

Modified Paths:
--------------
    branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java

Modified: branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java
===================================================================
--- branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java	2014-07-13 12:23:29 UTC (rev 8540)
+++ branches/BIGDATA_RELEASE_1_3_0/bigdata-sails/src/java/com/bigdata/rdf/sail/webapp/InsertServlet.java	2014-07-13 12:25:31 UTC (rev 8541)
@@ -270,8 +270,14 @@
 
                 conn = getUnisolatedConnection();
 
-                /*
+                /**
                  * There is a request body, so let's try and parse it.
+                 * 
+                 * FIXME This does not handle .gz or .zip files. We handle this
+                 * in the
+                 * 
+                 * @see <a href="http://trac.bigdata.com/ticket/991" >REST API:
+                 *      INSERT does not handle .gz</a>
                  */
 
                 final RDFParser rdfParser = rdfParserFactory.getParser();
@@ -466,10 +472,16 @@
                         /**
                          * There is a request body, so let's try and parse it.
                          * 
-                         * <a href=
-                         * "https://sourceforge.net/apps/trac/bigdata/ticket/620"
-                         * > UpdateServlet fails to parse MIMEType when doing
-                         * conneg. </a>
+                         * @see <a href=
+                         *      "https://sourceforge.net/apps/trac/bigdata/ticket/620"
+                         *      > UpdateServlet fails to parse MIMEType when
+                         *      doing conneg. </a>
+                         * 
+                         *      FIXME This does not handle .gz or .zip files. We
+                         *      handle this in the
+                         * 
+                         * @see <a href="http://trac.bigdata.com/ticket/991"
+                         *      >REST API: INSERT does not handle .gz</a>
                          */
 
                         final String contentType = hconn.getContentType();

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.