bigdata-commit

[Bigdata-commit] SF.net SVN: bigdata:[3757] branches/QUADS_QUERY_BRANCH/bigdata/src/java/com /bigdata/relation/accesspath/AccessPath.java

[<tho...@us...>]

Revision: 3757
          http://bigdata.svn.sourceforge.net/bigdata/?rev=3757&view=rev
Author:   thompsonbry
Date:     2010-10-08 16:22:13 +0000 (Fri, 08 Oct 2010)

Log Message:
-----------
added more information in an exception.

Modified Paths:
--------------
    branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java

Modified: branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java
===================================================================
--- branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java	2010-10-08 14:57:36 UTC (rev 3756)
+++ branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java	2010-10-08 16:22:13 UTC (rev 3757)
@@ -354,7 +354,7 @@
         } else {
             if (localIndexManager == null) {
                 throw new RuntimeException("Local index manager not given but"
-                        + "access path specifies local index.");
+                        + " access path specifies local index: pred="+predicate);
             }
             this.indexManager = localIndexManager;
         }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bigdata-commit] SF.net SVN: bigdata:[3829] branches/QUADS_QUERY_BRANCH/bigdata/src/java/com /bigdata/relation/accesspath/AccessPath.java

[<tho...@us...>]

Revision: 3829
          http://bigdata.svn.sourceforge.net/bigdata/?rev=3829&view=rev
Author:   thompsonbry
Date:     2010-10-20 18:27:22 +0000 (Wed, 20 Oct 2010)

Log Message:
-----------
Optimization in AccessPath.  It had been modified such that it was no longer hitting the cached index references in SPORelation and LexiconRelation.  This fixes that.  There is a non-javadoc note in the code which indicates that this fix is a bit of a kludge, but it is the same known kludge which we have been relying on for a long time now - caching of the index references on the concrete IRelation class implementations. 

Modified Paths:
--------------
    branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java

Modified: branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java
===================================================================
--- branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java	2010-10-20 18:25:26 UTC (rev 3828)
+++ branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java	2010-10-20 18:27:22 UTC (rev 3829)
@@ -425,11 +425,21 @@
             // The predicate is not constrained to an index partition.
             pmd = null;
 
-            // Obtain the index.
-            final String fqn = AbstractRelation.getFQN(relation, keyOrder);
-
-            ndx = AbstractRelation.getIndex(indexManager, fqn, timestamp);
-
+            /*
+             * Obtain the index.
+             * 
+             * FIXME The getIndex(IKeyOrder) code path is optimized by
+             * SPORelation and LexiconRelation. However, we should have
+             * automatic caching of the index references to avoid the
+             * significant penalty of going down to the commitRecordIndex and
+             * Name2Addr each time we need to resolve an index. (Scale-out has
+             * separate caching for this in IndexManager.)
+             */
+            ndx = relation.getIndex(keyOrder);
+//            final String fqn = AbstractRelation.getFQN(relation, keyOrder);
+//
+//            ndx = AbstractRelation.getIndex(indexManager, fqn, timestamp);
+            
             if (ndx == null) {
 
                 throw new RuntimeException("No such index: relation="


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bigdata-commit] SF.net SVN: bigdata:[3847] branches/QUADS_QUERY_BRANCH/bigdata/src/java/com /bigdata/relation/accesspath/AccessPath.java

[<dm...@us...>]

Revision: 3847
          http://bigdata.svn.sourceforge.net/bigdata/?rev=3847&view=rev
Author:   dmacgbr
Date:     2010-10-27 10:27:22 +0000 (Wed, 27 Oct 2010)

Log Message:
-----------
Remove trap for zero partition count within 'estimateCost(...)'

Modified Paths:
--------------
    branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java

Modified: branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java
===================================================================
--- branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java	2010-10-26 16:31:54 UTC (rev 3846)
+++ branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java	2010-10-27 10:27:22 UTC (rev 3847)
@@ -71,7 +71,6 @@
 import com.bigdata.mdi.IMetadataIndex;
 import com.bigdata.mdi.LocalPartitionMetadata;
 import com.bigdata.rawstore.Bytes;
-import com.bigdata.relation.AbstractRelation;
 import com.bigdata.relation.AbstractResource;
 import com.bigdata.relation.IRelation;
 import com.bigdata.service.AbstractClient;
@@ -1583,15 +1582,15 @@
 
         if (partitionCount == 0) {
 
-//            /*
-//             * SWAG in case zero partition count is reported (I am not sure that
-//             * this code path is possible).
-//             */
-//            return new ScanCostReport(0L/* rangeCount */, partitionCount, 100/* millis */);
+            /*
+             * SWAG in case zero partition count is reported (I am not sure that
+             * this code path is possible).
+             */
+            return new ScanCostReport(0L/* rangeCount */, partitionCount, 100/* millis */);
         	/*
         	 * Should never be "zero" partition count.
         	 */
-        	throw new AssertionError();
+//        	throw new AssertionError();
 
         }
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

[Bigdata-commit] SF.net SVN: bigdata:[4287] branches/QUADS_QUERY_BRANCH/bigdata/src/java/com /bigdata/relation/accesspath/AccessPath.java

[<tho...@us...>]

Revision: 4287
          http://bigdata.svn.sourceforge.net/bigdata/?rev=4287&view=rev
Author:   thompsonbry
Date:     2011-03-09 19:41:46 +0000 (Wed, 09 Mar 2011)

Log Message:
-----------
javadoc edit.

Modified Paths:
--------------
    branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java

Modified: branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java
===================================================================
--- branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java	2011-03-09 17:36:10 UTC (rev 4286)
+++ branches/QUADS_QUERY_BRANCH/bigdata/src/java/com/bigdata/relation/accesspath/AccessPath.java	2011-03-09 19:41:46 UTC (rev 4287)
@@ -280,8 +280,6 @@
      * @param indexManager
      *            Access to the indices, resource locators, executor service,
      *            etc.
-     * @param timestamp
-     *            The timestamp of the index view.
      * @param predicate
      *            The constraints on the access path.
      * @param keyOrder


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.