From: Christiaan H. <chr...@we...> - 2006-09-18 15:29:47
|
I am unable at the moment (and perhaps for a while) to commit anything. I found some workaround for these problems though which you might want to implement for 1.2.9. Basically, the problem occurs only in Rich HTML templates, so we should make sure that on 10.3 we never return that templateFormat. So in [BDSKTemplate templateFormat] simply return BDSKUnknownTemplateFormat on 10.3 when we would have returned BDSKRichHTMLTemplateFormat. And also use the 10.3 method to get the string (without encoding and error). We might also add an exception for 10.3 in the attributedString method for the case of rich html format, as it should nbever be reached then. Another thing is the button title on the error dialog for version checking. The button title "OK" is ambiguous together with the text and the "Show Log" button. Christiaan > > On Thursday, September 14, 2006, at 08:38AM, Adam Maxwell > <ama...@ma...> wrote: > >>I was going to check in a fix for the bug Stefano reported, but we should >> decide what to do re: branching, since it's a 10.3-specific fix. Do we >> want to keep the trunk 10.3 compatible, or copy 1.2.8 to PANTHER_BRANCH >> (or something)? Or wait a week for bug reports on 1.2.8 and release a >> quick fix that works on both? I'd like to drop Panther support and stop >> using deprecated NSDocument methods, but there's no urgent need for it >> yet. > > Unfortunately, there's another 10.4-only method used in the template > export, and I don't see a workaround for it: > > [fileTemplate dataFromRange:NSMakeRange(0,[fileTemplate length]) > documentAttributes:mutableAttributes error:&error] > > in -[BibDocument attributedStringDataForPublications:usingTemplate:]. > Since this appears to only be used for AppleScript, perhaps it can be > disabled on 10.3.9 without much loss? I found this by adding > "-DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3" to other C flags > and recompiling, as the AppKit release notes say to do. Should have tried > that a long time ago. > > Adam > |