Re: [Bgpd-users] Patch for BGP/PathAttribute [bgpd.pl-0.06]

[Andrew - S. <an...@su...>]

>>>>> "Steven" == Steven Hessing <st...@xs...> writes:

 Steven> 0.07 won't be released until I've chased another bug report I
 Steven> received last week (keep them coming, it's nice to know that
 Steven> people are using the software!)

Hm, a year and a half later... :-)

Here is another bug in PathAttribute in 0.06 that causes the session
to be aborted typically with Notification 3/1 any time an unknown
attribute is seen; $bytes_read wasn't being updated in this case, so
the unknown attribute's data was being parsed as more attributes.
(Someone's leaking a NEW_AS_PATH into the backbone at the moment,
apparently due to a misconfiguration rather than any legitimate use of
a 32-bit ASN.)

--- PathAttribute.pm.orig	Mon Sep 13 01:44:21 2004
+++ PathAttribute.pm	Mon Sep 13 01:44:57 2004
@@ -629,6 +629,7 @@
 					# unknown optional non-transitive attributes
 					# can be discarded
 				}
+				$bytes_read += $attribute_length;
 			} else {
 				# If this is a well-known attribute then we have
 				# to raise an error and send a NOTIFICATION.


-- 
Andrew, Supernews
http://www.supernews.com