Hi Michael,
> i'm using beepcore-java for using in jboss. i have some whishes
> regarding the usability of the implementation, can you please
Great!
> - make src/org/beepcore/beep/core/ProfileRegistry.profileListeners
> protected and make
> src/org/beepcore/beep/core/ProfileRegistry.ProfileRegistry(String
> localize, Hashtable profiles) protected, that way i can derive a
> class to implement a own profile
To implement your own profile you shouldn't need to sub-class
ProfileRegistry, just implement StartChannelListener and register it with a
ProfileRegistry. If there is a reason why this won't work for the profile
you are implementing please detail the problem and I'll do my best to
implement a fix.
> - make src/org/beepcore/beep/core/ChannelImpl public and make
> src/org/beepcore/beep/core/ChannelImpl.getState() public;
> alternativly: put getState into the interface; alternativly
> implement a proper toString() methode for logging
I would prefer to not make ChannelImpl public because I'm in the process of
trying to minimize and cleanup the public interface but making getState
public or fixing toString is not a problem. What information would you like
to see in toString?
> - remove all properties alread in build.properties(.example) from
> build.xml
thanks.
> - make & in a profile url work, a '&' put into an url leads to an
> xml parser exception
ah, so we are not escaping '&' when we are creating start channel requests?
> - make org.beepcore.beep.lib.Reply recycleable, if you use a Reply
> object more than once it closes the channel in the current
> implementation
We hadn't done this to avoid problems with people using the class. How would
you like to see this feature? Would you call an init() method on Reply when
you want to recycle the object? What are your thoughts?
> - remove the default ctor of
> org.beepcore.beep.core.OutputDataStream, the default ctor
> initilizes this.mimeHeaders = null; which leads to a stream
> ignoring any content.
I did this intensionally since mime headers aren't required for BEEP to work
I wanted to provide a what to send and receive messages without headers. The
intent was messages that want mime headers would sub-class OutputDataStream
e.g. StringOutputDataStream.
> p.s.: i really like beepcore-java and thnx very much for the work of
> huston. i do not want to sound offensive here, if so it's coming
> from my bad english, english isn't my first language, thnx for your
> understanding.
Thank you. No offense taken, your English is quite good.
BTW, I'm trying to get a new release out right now. I will try to add the
simple requests like making getState() public for this release.
--Huston
--Huston
|
