beepcore-java-users — Discussion list for developers using beepcore-java library

Re: [Beepcore-java-users] [PATCH] for logging

[Harrie H. <ha...@in...>]

David Blacka wrote:
> Harrie Hazewinkel wrote:
> 
>> HI,
>>
>> While checking out the functionality of beepcore-java
>> I run into a problem of the API with log4j. Attached is a
>> patch that fixes the code for a recent 1.3 version of log4j.
>> Hope it will be applied.
> 
> 
> What was the actual problem?
> 
> I will note that the commons-logging package will absolutely use log4j 
> if  log4j is present in the classpath.  You should be able to configure 
> log4j first, and control the behavior of the commons-logging package. At 
> that point, it is just a basic wrapper around log4j.
> 

While compiling the code I got a lot of errors, like package not found
(due to classpatch indeed), but also some method API problems.
While investigating I saw you seemed to have a different API
for it (the common-logging), so I changed it directly into a recent
version of the log4j.

I did not follow log4j that close, but if I understand it well
it as become a more 'stand-alone' package with the name log4j.
The logging-common is still there, but would you really keep that
layer in between? You may decide that.


cheers,
Harrie

[Beepcore-java-users] Jessie Free JSSE Implementation

[<tob...@cs...>]

Hi all,

Has anyone ever tried to integrate this free J2SSE with java-beepcore?

http://www.nongnu.org/jessie/

It appears on the surface like it might serve as a drop in replacement fo=
r
j2sse, enabling a more Free Beep w/ TLS Tuning profile implementation. I'=
m
particularly interested in it so that I can compile java-beepcore with GC=
J
for  Linux.

If anyone has had any experience with this library any comments would be
greatly appreciated.

If I integrate it, would patches be interesting to anyone?

Thanks
Toby

Re: [Beepcore-java-users] using beepcore-java as 'client' or channel initiator'

[Harrie H. <ha...@in...>]

Wladimir Araujo wrote:
> 	Hi, Harrie,
> 
> 	If you want to start a channel with piggyback data, you need to
> apply the patch I provided for the 0.9.08 version and then just follow
> the API as is.

OK, I will do that.

> The discussion about Reply listeners is for the future.

Just wondering, but how much work is still being done with
beepcore-java? Do you know (or someone else)?


Harrie

RE: [Beepcore-java-users] using beepcore-java as 'client' or channel initiator'

[Wladimir A. <wa...@ju...>]

	Hi, Harrie,

	If you want to start a channel with piggyback data, you need to
apply the patch I provided for the 0.9.08 version and then just follow
the API as is. The discussion about Reply listeners is for the future.

		Cheers,

Wladimir de Lara Araujo Filho
Juniper Networks, Inc.

-----Original Message-----
From: bee...@li...
[mailto:bee...@li...]On Behalf Of
Harrie Hazewinkel
Sent: Monday, September 13, 2004 4:16 AM
To: beepcore java
Subject: [Beepcore-java-users] using beepcore-java as 'client' or
channel initiator'


HI,

I have a question with repsect to the beepcore-java as a
channel initiator.

I read the thread with respect to the PiggyBack data, but still have
doubts if I am understanding it. I would like to start a channel
with piggyback data (or even without), but it seems that the
startChannel methods in the SessionImpl class can only use
a RequestHandler and a ReplyListener is made inside this class.

However, how can I start a channel as a 'client' and have my own
ReplyListener attached to it? Am I correct that I should
change the startChannel API and add a ReplyListener parameter?


thanks by advance,
Harrie



-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.=20
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
_______________________________________________
Beepcore-java-users mailing list
Bee...@li...
https://lists.sourceforge.net/lists/listinfo/beepcore-java-users

[Beepcore-java-users] using beepcore-java as 'client' or channel initiator'

[Harrie H. <ha...@in...>]

HI,

I have a question with repsect to the beepcore-java as a
channel initiator.

I read the thread with respect to the PiggyBack data, but still have
doubts if I am understanding it. I would like to start a channel
with piggyback data (or even without), but it seems that the
startChannel methods in the SessionImpl class can only use
a RequestHandler and a ReplyListener is made inside this class.

However, how can I start a channel as a 'client' and have my own
ReplyListener attached to it? Am I correct that I should
change the startChannel API and add a ReplyListener parameter?


thanks by advance,
Harrie

[Beepcore-java-users] [PATCH] for logging

[Harrie H. <ha...@in...>]

HI,

While checking out the functionality of beepcore-java
I run into a problem of the API with log4j. Attached is a
patch that fixes the code for a recent 1.3 version of log4j.
Hope it will be applied.


Harrie

Re: [Beepcore-java-users] Piggyback data API deprecated.

[Huston <hu...@us...>]

You are correct about the state of the piggybacked requests. I haven't 
added anything to the API for the initiator side because I haven't found 
a design that felt comfortable yet. The idea I have been toying with is 
passing  a ReplyListener into the startChannel call and then mapping the 
reply into a InputDataStream in a similar way to what is happening on 
the listener side (input is welcome). I deprecated the set/getStartData 
APIs a bit prematurely to let people writing listener profiles know that 
they shouldn't be using them. Unfortunately it creates a problem for 
people writing initiator profiles.

--Huston

Wladimir Araujo wrote:

>	These methods have been deprecated, yes. For you to piggyback
>data you can do the following:
>
>	send it with (Session):
>
>		public Channel startChannel(String profile, boolean
>base64Encoding,
>                                String data)
>            throws BEEPException, BEEPError;
>
>	you'll get it on the other side with (Channel):
>
>		public void startChannel(Channel channel, String
>encoding, String data)
>        throws StartChannelException;
>
>	There was (is), however, a problem with the SessionImpl start-up
>(processStartChannel). I had submitted a fix a while ago, but I don't
>know the status of where it went. I am attaching my previous message
>with the fix. The detail is that you must send back some data (using
>setStartChannel). That solved my problem. Maybe you can improve the fix
>in the case no reply is sent.
>
>	I hope it helps. Detail: I still use the deprecated methods.
>
>		Cheers,
>
>Wladimir de Lara Araujo Filho
>Juniper Networks, Inc.
>
>
>-----Original Message-----
>From: bee...@li...
>[mailto:bee...@li...]On Behalf Of
>Greg Wilkins
>Sent: Sunday, July 25, 2004 10:49 PM
>To: bee...@li...
>Subject: [Beepcore-java-users] Piggyback data API deprecated.
>
>
>
>The setStartData and getStartData methods have been deprecated, but I 
>can't see how to avoid their use to receive a piggyback reply?
>
>You can send piggyback data with an arg to startChannel.
>You can receive piggyback data with a RequestHandler and send a reply 
>normally.
>
>But I can't see how to receive this reply without using getStartData
>after the startChannel?
>
>I'm also seeing a problem that after using piggyback data, the channel
>does not appear to work.  But I think this is a bug in 0.9.08 that has
>been discussed in the "PiggyBacked data, MessageListener and 
>RequestHandler" thread.
>
>regards
>
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by BEA Weblogic Workshop
>FREE Java Enterprise J2EE developer tools!
>Get your free copy of BEA WebLogic Workshop 8.1 today.
>http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click
>_______________________________________________
>Beepcore-java-users mailing list
>Bee...@li...
>https://lists.sourceforge.net/lists/listinfo/beepcore-java-users
>  
>
>
> ------------------------------------------------------------------------
>
> Subject:
> PiggyBacked data, MessageListener and RequestHandler (simple fix)
> From:
> "Wladimir Araujo" <wa...@ju...>
> Date:
> Wed, 11 Feb 2004 11:32:45 -0400
> To:
> "Beepcore \(E-mail\)" <bee...@li...>
>
> To:
> "Beepcore \(E-mail\)" <bee...@li...>
>
>
>	Hi,
>
>	Since I did not hear from anybody in this respect, I'm adding this simple fix. The piggybacked stuff remains there and the TCPSession is recreated afterwards. This only works if StartChannelListener.startChannel() calls channel.setStartData() to send back a piggybacked reply, otherwise the session will die if the new channel does not reply to the piggybacked message. The patch is below.
>
>		Cheers,
>
>--- SessionImpl.java.new        Wed Feb 11 10:21:28 2004
>+++ SessionImpl.java.old        Wed Feb 11 10:24:09 2004
>@@ -1321,7 +1321,7 @@
> 
>                 fireChannelStarted(ch);
> 
>-                if (ch.getState() != ChannelImpl.STATE_TUNING) {
>+                if (p.data == null && ch.getState() != ChannelImpl.STATE_TUNING) {
>                     this.enableIO();
>                 }
>             }
>
>Wladimir de Lara Araujo Filho
>Juniper Networks, Inc.
>
>  
>

RE: [Beepcore-java-users] Piggyback data API deprecated.

[Wladimir A. <wa...@ju...>]

	These methods have been deprecated, yes. For you to piggyback
data you can do the following:

	send it with (Session):

		public Channel startChannel(String profile, boolean
base64Encoding,
                                String data)
            throws BEEPException, BEEPError;

	you'll get it on the other side with (Channel):

		public void startChannel(Channel channel, String
encoding, String data)
        throws StartChannelException;

	There was (is), however, a problem with the SessionImpl start-up
(processStartChannel). I had submitted a fix a while ago, but I don't
know the status of where it went. I am attaching my previous message
with the fix. The detail is that you must send back some data (using
setStartChannel). That solved my problem. Maybe you can improve the fix
in the case no reply is sent.

	I hope it helps. Detail: I still use the deprecated methods.

		Cheers,

Wladimir de Lara Araujo Filho
Juniper Networks, Inc.


-----Original Message-----
From: bee...@li...
[mailto:bee...@li...]On Behalf Of
Greg Wilkins
Sent: Sunday, July 25, 2004 10:49 PM
To: bee...@li...
Subject: [Beepcore-java-users] Piggyback data API deprecated.



The setStartData and getStartData methods have been deprecated, but I=20
can't see how to avoid their use to receive a piggyback reply?

You can send piggyback data with an arg to startChannel.
You can receive piggyback data with a RequestHandler and send a reply=20
normally.

But I can't see how to receive this reply without using getStartData
after the startChannel?

I'm also seeing a problem that after using piggyback data, the channel
does not appear to work.  But I think this is a bug in 0.9.08 that has
been discussed in the "PiggyBacked data, MessageListener and=20
RequestHandler" thread.

regards



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=3D4721&alloc_id=3D10040&op=3Dclick
_______________________________________________
Beepcore-java-users mailing list
Bee...@li...
https://lists.sourceforge.net/lists/listinfo/beepcore-java-users

RE: [Beepcore-java-users] BEEPCORE downloads

[Woloszynski, C. <Cha...@in...>]

Yes, I was able to download it after ding just what you suggested.
Apparently, the download server's DNS server was glitching.  Filed an SF
report and it cleared up within an hour. =20

Thanks for the assist.

Charlie Woloszynski
Innovative Concepts Inc.
703-893-2007 x506=20
cha...@in...

-----Original Message-----
From: Huston [mailto:hu...@us...]=20
Sent: Sunday, July 25, 2004 11:00 AM
To: Woloszynski, Charles
Cc: bee...@li...
Subject: Re: [Beepcore-java-users] BEEPCORE downloads


Charlie,

I just downloaded both archives without any errors. I would suggest=20
trying the download again and then contacting SF support if you continue

to experience problems.

--Huston

Woloszynski, Charles wrote:

> I am trying to download the beepcore 0.9.08 to try it out and I am
> getting errors.  Is this code still available?  What is its status? =20
> Known defects?
>
>
> Charlie
>

[Beepcore-java-users] Piggyback data API deprecated.

[Greg W. <gr...@mo...>]

The setStartData and getStartData methods have been deprecated, but I 
can't see how to avoid their use to receive a piggyback reply?

You can send piggyback data with an arg to startChannel.
You can receive piggyback data with a RequestHandler and send a reply 
normally.

But I can't see how to receive this reply without using getStartData
after the startChannel?

I'm also seeing a problem that after using piggyback data, the channel
does not appear to work.  But I think this is a bug in 0.9.08 that has
been discussed in the "PiggyBacked data, MessageListener and 
RequestHandler" thread.

regards

Re: [Beepcore-java-users] BEEPCORE downloads

[Huston <hu...@us...>]

Charlie,

I just downloaded both archives without any errors. I would suggest 
trying the download again and then contacting SF support if you continue 
to experience problems.

--Huston

Woloszynski, Charles wrote:

> I am trying to download the beepcore 0.9.08 to try it out and I am 
> getting errors.  Is this code still available?  What is its status?  
> Known defects?
>
>
> Charlie
>

[Beepcore-java-users] Kin Ng is out of the office.

[Kin Ng <ki...@us...>]

I will be out of the office starting  07/07/2004 and will not return until
08/09/2004.

I will respond to your message when I return.

[Beepcore-java-users] BEEPCORE downloads

[Woloszynski, C. <Cha...@in...>]

I am trying to download the beepcore 0.9.08 to try it out and I am
getting errors.  Is this code still available?  What is its status?
Known defects?


Charlie

[Beepcore-java-users] Status report?

[Greg W. <gr...@mo...>]

Would it be possible to get a status report from the beepcore-java developers
as to the current status of the project?

I've picked up the work that Paul Andrews was doing on improved SASLProfile for
beepcore eventually would like to contribute it back to the project.

But I'm a bit concerned at how quiet things are.  There have been no commits
since January and little list traffic.  Is this because 0.9.08 was near perfect
or is it just that the main developers have other things to do?

cheers

[Beepcore-java-users] PureTLS question

[Dong X. <dx...@nc...>]

Hi,

	It seems that in TLSProfilePureTLS, Certificates, Private
Key and Private Key Passphrase at the client side are always needed 
to be submitted, even if "Client Authenticaton Required" is set 
as "false" at the server side.
	
	I am wondering why beepcore has this restriction, did I miss
something there?

	Thanks...

Dong

[Beepcore-java-users] PureTLS with mutual authentication

[Dong X. <dx...@nc...>]

Hi,

	I was using PureTLS to achieve mutual authentication.
The code was modified from beepcore-java's example. The key,
certificate and trusted certificate are specified on both side.
After initiation, the startTLS operation executed successfully, and the 
echo channel ran with no problem too. However, when I tried to use 
session.getPeerCredential() (right after startTLS at client side)
to get the credential on the server side,
the method return null. The API said getPeerCredential "may return
null if this session has not been authenticated".
	
	I wonder how to verify that the TLS session has been 
sucessfully created and the mutual authentication is finished? 
I was trying to print out the subject of the certificate on
the other side, is it right to use getPeerCredential()? 

	Thanks a lot...

Dong  

[Beepcore-java-users] TLS mutual authentication

[Dong X. <dx...@nc...>]

Hi,

	I was running the simple example provided by beepcore-java.
It seems the example does not require authentication to start TLS.
Does anyone has experience on running TLS with mutual authentication?
Thanks a lot.

Dong

Re: [Beepcore-java-users] Help on beepcore-java

[Andrew N. <an...@hx...>]

On May 25, 2004, at 11:51 AM, Dong Xin wrote:

> Hi,
>
> 	I am a new user of beepcore. I am
> wondering if anybody has some examples. I saw
> there was an example in the source code, but
> it seems too simple, I'd like to see more
> examples. Thanks a lot.
>
> Dong
>

I think, for the most part, they are that simple.  Marshall Rose's book 
also has some examples.

-andy

[Beepcore-java-users] Help on beepcore-java

[Dong X. <dx...@nc...>]

Hi,

	I am a new user of beepcore. I am
wondering if anybody has some examples. I saw
there was an example in the source code, but 
it seems too simple, I'd like to see more 
examples. Thanks a lot.

Dong



  

Re: [Beepcore-java-users] BEEPcore broken w.r.t. TCP

[Mario J. <ma...@je...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

| Forgive me for my ignorance but I don't understand how an application >can
| keep TCP stack from sending CLOSE? Can you describe a simple scenario
|that
| I can simulate to reproduce this bug (not necessarily with
|beepcore-java).

Using BEEPing (which is shipped as a sample application bundled with
beepcore-java) on Linux should do the trick, unfortunately.

Just echo a few bytes between client and server and you should be able
to reproduce the sockets kept open at the server side.

It seems to work also under WindowsXP, whereas after reaching 15 open
sockets in state WAIT_CLOSE all sockets will be closed by the operating
system.

Best,
Mario
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFASikM46tt20EwGqwRAvB8AJ4+KpTqfQ7OmRCM7kbMEsiVSkYbGwCgmW9J
Mv0Pvj/rUFQ0EjcnMpmmGBI=
=Pr4C
-----END PGP SIGNATURE-----

Re: [Beepcore-java-users] BEEPcore broken w.r.t. TCP

[Harsh D. <hda...@io...>]

Forgive me for my ignorance but I don't understand how an application can
keep TCP stack from sending CLOSE? Can you describe a simple scenario that
I can simulate to reproduce this bug (not necessarily with beepcore-java).

Harsh
Mario Jeckle said:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Working these days on a research prototype with the lasted
> implementation of BEEP available from www.beepcore.org we discovered a
> serious flaw.
>
> Obviously the library does not issue TCP's CLOSE command after having
> received the CLOSING primitive which is received as a result of an TCP
> packet flagged with FIN. Actually, the ACK flagged message is sent back
> to the client by the server, but the required FIN message is missing.
>
> As a result of this the TCP connection of the server side remains in
> status CLOSE_WAITING almost forever until the process is killed or the
> machine is rebooted.
>
> This can be reproduced under various Linux versions including the
> latest kernel (i.e., 2.6.3) and even machines running Windows.
> Fortunately, Windows (XP) limits the number of processed in state
> CLOSE_WAITING to 15 per process and cleans the open connections without
> user interaction automatically if an additional one reaches the
> mentioned state.
>
> Concerning Unix/Linux versions (the problem of remaining CLOSE_WAITING
> connections is also reported for HP UX) this behavior of BEEPcore might
> introduce the possibility of attacking the machine running BEEP since
> the server will run out of free sockets after a while.
>
> Could you please re-check this since it hinders us from using BEEP in
> practice.
>
> Also feedback on this issue and even potential mistakes from our side
> is highly appreciated.
>
> Best,
> Mario
>
> - --
> Prof. Mario Jeckle
> University of Applied Sciences Furtwangen
> Dept. Business Applications of Computer Science
>
> W3C Representative of DaimlerChrysler Research and Technology
> OMG Representative of DaimlerChrysler
>
> URL: http://www.jeckle.de
> MailTo:ma...@je...
> MailTo:je...@fh...
>
> My public key: http://www.jeckle.de/marioJeckle.pub
>
> [mail really from me _always_ has this signature and is signed
> digitally - -- mail without it is forged spam]
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
>
> iD8DBQFAQYMQ46tt20EwGqwRAkY7AKC87JxDWLTOJZFIEPU/DYY0jjjGOwCff29G
> lW8fiQ8bYCRDcAEez7Sf0CQ=
> =l6YW
> -----END PGP SIGNATURE-----
>
>
> -------------------------------------------------------
> SF.Net is sponsored by: Speed Start Your Linux Apps Now.
> Build and deploy apps & Web services for Linux with
> a free DVD software kit from IBM. Click Now!
> http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
> _______________________________________________
> Beepcore-java-users mailing list
> Bee...@li...
> https://lists.sourceforge.net/lists/listinfo/beepcore-java-users


-- 
Harsh Daharwal
IOS Networks Inc.
http://www.iosnetworks.com

[Beepcore-java-users] BEEPcore broken w.r.t. TCP

[Mario J. <ma...@je...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Working these days on a research prototype with the lasted
implementation of BEEP available from www.beepcore.org we discovered a
serious flaw.

Obviously the library does not issue TCP's CLOSE command after having
received the CLOSING primitive which is received as a result of an TCP
packet flagged with FIN. Actually, the ACK flagged message is sent back
to the client by the server, but the required FIN message is missing.

As a result of this the TCP connection of the server side remains in
status CLOSE_WAITING almost forever until the process is killed or the
machine is rebooted.

This can be reproduced under various Linux versions including the latest
kernel (i.e., 2.6.3) and even machines running Windows. Fortunately,
Windows (XP) limits the number of processed in state CLOSE_WAITING to 15
per process and cleans the open connections without user interaction
automatically if an additional one reaches the mentioned state.

Concerning Unix/Linux versions (the problem of remaining CLOSE_WAITING
connections is also reported for HP UX) this behavior of BEEPcore might
introduce the possibility of attacking the machine running BEEP since
the server will run out of free sockets after a while.

Could you please re-check this since it hinders us from using BEEP in
practice.

Also feedback on this issue and even potential mistakes from our side is
highly appreciated.

Best,
Mario

- --
Prof. Mario Jeckle
University of Applied Sciences Furtwangen
Dept. Business Applications of Computer Science

W3C Representative of DaimlerChrysler Research and Technology
OMG Representative of DaimlerChrysler

URL: http://www.jeckle.de
MailTo:ma...@je...
MailTo:je...@fh...

My public key: http://www.jeckle.de/marioJeckle.pub

[mail really from me _always_ has this signature and is signed digitally
- -- mail without it is forged spam]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAQYMQ46tt20EwGqwRAkY7AKC87JxDWLTOJZFIEPU/DYY0jjjGOwCff29G
lW8fiQ8bYCRDcAEez7Sf0CQ=
=l6YW
-----END PGP SIGNATURE-----

Re: [Beepcore-java-users] PiggyBacked data, MessageListener and RequestHandler (simple fix)

[William J. M. <wm...@es...>]

Vladimir,

I had hoped Huston would respond.  I am not strong at all
on the Java implementation, so I was staying to the side.

If you don't mind, please let us know how this works after you have
shaken it out a bit, and then perhaps we can see about getting it
checked in, and hopefully Huston will re-surface and can comment on
how the API would be affected.

I suspect your change is probably right.

Regards,

-bill mills


On Wed, Feb 11, 2004 at 10:32:45AM -0500, Wladimir Araujo wrote:
> 	Hi,
>=20
> 	Since I did not hear from anybody in this respect, I'm adding this simpl=
e fix. The piggybacked stuff remains there and the TCPSession is recreated =
afterwards. This only works if StartChannelListener.startChannel() calls ch=
annel.setStartData() to send back a piggybacked reply, otherwise the sessio=
n will die if the new channel does not reply to the piggybacked message. Th=
e patch is below.
>=20
> 		Cheers,
>=20
> --- SessionImpl.java.new        Wed Feb 11 10:21:28 2004
> +++ SessionImpl.java.old        Wed Feb 11 10:24:09 2004
> @@ -1321,7 +1321,7 @@
> =20
>                  fireChannelStarted(ch);
> =20
> -                if (ch.getState() !=3D ChannelImpl.STATE_TUNING) {
> +                if (p.data =3D=3D null && ch.getState() !=3D ChannelImpl=
.STATE_TUNING) {
>                      this.enableIO();
>                  }
>              }
>=20
> Wladimir de Lara Araujo Filho
> Juniper Networks, Inc.
>=20
>=20
>=20
> -------------------------------------------------------
> SF.Net is sponsored by: Speed Start Your Linux Apps Now.
> Build and deploy apps & Web services for Linux with
> a free DVD software kit from IBM. Click Now!
> http://ads.osdn.com/?ad_id=1356&alloc_id438&op=CCk
> _______________________________________________
> Beepcore-java-users mailing list
> Bee...@li...
> https://lists.sourceforge.net/lists/listinfo/beepcore-java-users

[Beepcore-java-users] PiggyBacked data, MessageListener and RequestHandler (simple fix)

[Wladimir A. <wa...@ju...>]

	Hi,

	Since I did not hear from anybody in this respect, I'm adding this =
simple fix. The piggybacked stuff remains there and the TCPSession is =
recreated afterwards. This only works if =
StartChannelListener.startChannel() calls channel.setStartData() to send =
back a piggybacked reply, otherwise the session will die if the new =
channel does not reply to the piggybacked message. The patch is below.

		Cheers,

--- SessionImpl.java.new        Wed Feb 11 10:21:28 2004
+++ SessionImpl.java.old        Wed Feb 11 10:24:09 2004
@@ -1321,7 +1321,7 @@
=20
                 fireChannelStarted(ch);
=20
-                if (ch.getState() !=3D ChannelImpl.STATE_TUNING) {
+                if (p.data =3D=3D null && ch.getState() !=3D =
ChannelImpl.STATE_TUNING) {
                     this.enableIO();
                 }
             }

Wladimir de Lara Araujo Filho
Juniper Networks, Inc.

[Beepcore-java-users] PiggyBacked data, MessageListener and RequestHandler

[Wladimir A. <wa...@ju...>]

	Hi,

	I had code that was using the 0.9.07 library and it used the =
MessageListener interface. Now that I upgraded to the 0.9.08 it =
complains about deprecation (the setMessageListener() method is =
deprecated on the Channel interface (which was a class before)). That =
is, of course, not a problem in itself. The question is: should I =
rewrite the code to not use the MesageListener interface anymore (which =
is fine), in which case the interface should be deprecated or should I =
attempt a fix to this (I cannot throw a BEEPError on a piggybacked msg =
and that destroys my code...)?=20

	I noticed a different handling regarding what is now called a =
PiggybackedMSG. It is actually sent to the newly created channel as a =
regular message (which, IMO, should not be the case, since the =
startChannel() already got it as part of the String data argument). The =
major problem is that my old code does not work anymore. It looks like I =
have to reply to this PiggybackedMsg to continue with the channel =
start-up process. I'm trying to understand why this is done this way =
and, more importantly, how I should proceed.

	My idea for a fix would be to get rid of this piggybacked stuff and use =
the regular (deprecated) setStartData() (I know it's not the best but =
it's better than the current handling). Another option would be to pass =
a holder object instead of the simple String data, which, if modified =
inside startChannel(), would be sent back as embedded data to the =
profile RPY. In both alternatives, sending a content back is not =
mandatory (even if it's empty, if you don't reply to the PiggybackedMSG =
your session is gone). The second one has the problem of changing the =
interface StartChannelListener, but it is a straightforward change.

	Opinions, thoughts...

		Cheers,

Wladimir de Lara Araujo Filho
Juniper Networks, Inc.