Be::Battery : Bug and reclamations

[Hoël]

Hello,

I'm new with BE:Shell and I'm trying to create something usable. ^^
I'm currently aving troubles with the Battery applet.
I was told that the following code in style.css allowed me to set a style for the battery when it was not loading :

.BE--Battery[charging="false"] {
    color: qlineargradient(x1:0.5, y1:0, x2:0.5, y2:1, stop:0 #303030, stop:1 #800000);
}

BUT, it overrides my settings set for .BE--Battery,no matter if it is loading or not. Setting charging to "true" causes this code to do nothing (nothing I can see anyway).
So I wanted to know if I missed something or if it is a bug (it is a recent feature).

I also have a few reclamations ^^
Now we can change the colors according to the loading state, could we also prevent the icon from indicating it ? Because it's turning around, and I would like to keep it in one direction.

And I think the colors groups are not instinctive. The color which indicate the load amount is different from the border color, while I would have tell it should be the same. So when I look at my battery, I always think it's empty, though it's full.
Of course, everybody may not agree with me, but if we could choose what we want in the configuration, that would be great.

Thank you for your help !

[Thomas Luebking]

Do you have commit fe4d251a30bd807b567d779ac9595d383da48858 for sure? (and recompiled/installed ;-)

The property is false by default, but should become true when the charging state changes.
Is the state change detected (does the direction swap when plugging in/out AC)?

The color which indicate the load amount is different from the border color
Errr... do you complain because you can set them independently?

[Hoël]

I don't know how to get the name of a commit but git pull says my version is up-to-date. And I have recompiled and installed several times.

The change state is detected, because the direction does swap. But the colors doesn't.

Errr... do you complain because you can set them independently?

No. ^^
I mean that the border color is also the color used for the empty part of the battery and the full part of the battery is another color. I would have said that the border color is the same as the full part, and the empty part is another color. I don't know if that's clear... ^^ Do you want a screenshot to explain ?

[Thomas Luebking]

"git log" =)

I mean that the border color is also the color used for the empty part of the battery and the full part of the battery is another color.
Ah, you mean "there should be a border around the empty section" - for there's not at all.

[Hoël]

>>> "fe4d251a30bd807b567d779ac9595d383da48858" == "fe4d251a30bd807b567d779ac9595d383da48858"
True

I have the latest commit of BE::Shell. ^^

And it is what I mean, that the border should be around the empty section, and not the full section. Or that we should, at least, have the choice. Because when I see this, I think my battery is nearly empty, while it's nearly full.

[Hoël]

I keep testing the "charging" option.

If set to false, nothing happen. If set to true, it overrides the default config.

In both case, I can plug and unplug my computer, the battery switch of direction, but the colors doesn't change.

That's all.

[Hoël]

Ok, I turned my computer off and restarted it later. And now, the problem is inversed. False and it's overriden, True and nothing happens.

I think that the charging variable is set to something at the beginning of the session, according to the state at that moment, and then it doesn't change. There must be a problem in your code which prevent it to change of value.

[Thomas Luebking]

Tssstssstsss... there is no problem in my code!
There was a problem in my code ;-)

The property was only altered when a charge level state would cross a charging state - I forgot to alter it for pure state changes.

[Hoël]

I works now ! ^^
So the bug is corrected, but I still have reclamations !
The most important is : could we prevent the direction of the icon to swap ?
Because with a lineargradient color, it's not very nice : the colors at the top go at the bottom and vice versa.

Thank you for being so efficient anyway ! ^^

[Hoël]

I keep having idea about the battery applet (I won't get up until it does what I want ^^).

I noticed that when the battery is full, the charging variable is set to false, even if the computer is still plug in. Is it wanted or didn't you take care of it (you may not use a laptop...)?

Anyway, I took a look at your code (battery.cpp), and I think this come from the > sign in these two locations:

for (QMap<QString, int>::const_iterator it = myBatteries.constBegin(),
                                            end = myBatteries.constEnd(); it != end; ++it)
    {
        if (*it > 0)
        {
            iAmCharging = true;
            myCharge += *it;
        }
        else
            myCharge -= *it;
    }

lines 124-134

for (QMap<QString, int>::const_iterator it = myBatteries.constBegin(), end = myBatteries.constEnd(); it != end; ++it)
        {
            if (*it > 0)
            {
                iAmCharging = true;
                break;
            }
        }
        if (wasCharging != iAmCharging) {
            setProperty("charging", iAmCharging);
            repolish();
        }

lines 277-288

Replacing the > by something like >= could resolv this problem (if you consider it is one), but I don't know if I'm right, so I haven't made anything.

Thanks !

[Thomas Luebking]

That won't do.
It'll be required to handle this along lines 74, 264 and 274, ie. check whether the charging state is NoCharge and pass the entry a "special" value (101)

I left it as a bool, because the "discharging" icon tells me that the battery is full (and I can see that there's a wire plugged into the device ;-)

[Hoël]

Got it ! ^^

Thanks !

[Thomas Luebking]

The most important is : could we prevent the direction of the icon to swap ?

If I get you right, your actual grief is not that the icon reverses the direction

||||: <-> :||||

but that the inner area indicates the filled rather than the unfilled capacity, ie. you'd like the 100% charged battery to be single colored and the empty battery to look like the 100% charged one does right now?

[Hoël]

No I dealt with the current possibilities and we had an agreement. ^^

the inner area indicates the filled rather than the unfilled capacity

That would be a good thing but I managed without. So if you want to allow that, just do and I'll be glad, but that's not (anymore) my main problem.

No, I actualy want the battery to stay that way :

||||:

Because when it changes of direction, it's not only right/left but also top/bottom, and with lineargradient colors, That's not always very nice.

I also found a bug : sometimes, on startup, the charge variable is not set, or doesn't seem to, because the selection-background-color of battery is the default one. Here is my style.css :

/*Battery*/

.BE--Battery {
    padding-top:4px;
    padding-bottom:4px;
    color:qlineargradient(x1:0.5, y1:0, x2:0.5, y2:1, stop:0 #585858, stop:1 #303030);
    /*selection-background-color:qlineargradient(x1:0.5, y1:0, x2:0.5, y2:1, stop:0 #808080, stop:1 #303030);*/
    padding-right:4px;
}

.BE--Battery[charge="high"] {
    selection-background-color:qlineargradient(x1:0.5, y1:0, x2:0.5, y2:1, stop:0 #00D000, stop:1 #005000);
}

.BE--Battery[charge="mid"] {
    selection-background-color:qlineargradient(x1:0.5, y1:0, x2:0.5, y2:1, stop:0 #FF8000, stop:1 #C05800);
}

.BE--Battery[charge="low"] {
    selection-background-color:qlineargradient(x1:0.5, y1:0, x2:0.5, y2:1, stop:0 #C00000, stop:1 #800000);
}

.BE--Battery[charging="false"] {
    color: qlineargradient(x1:0.5, y1:0, x2:0.5, y2:1, stop:0 #800000, stop:1 #400000);
}

The selection-background-color is only made with the charge variable, as you can see.

Thanks, and sorry changing my mind every five posts ! ^^

[Thomas Luebking]

but also top/bottom, and with lineargradient colors
Ah - but that's an implementation detail (as long as the object is symmetric, it doesn't matter whether it's mirrored or rotated 180°)

-> commit 126dcdfda9624a258d1a380a5dd134c658f351c7

sometimes, on startup, the charge variable is not set

-> commit 231ef71472226aa7f040f13dde6b5e171af9dd09

[Hoël]

Thanks ! That's just perfect ! ^^