Stupid idea for icons management

[Hombremaledicto]

I recently started to have fun using custom icons by placing them in the theme directory, but i've found that - if you set the tray and tasks applets to be in two different panels( with different background colors) each one - it may lead to ugly results.
One can always set the Icon field for sticky buttons in the taskbar of course (to use a png with a different name), but this has no effect on those applications which are not sticked in the applet.
So here's my terrible idea: why don't we place custom icons in an "Icon" folder within the theme one using subdirectories, like "Taskbar" "SysTray" and even "Menu"?
This would be helpful for theming, and to keep order in the theme folder.
I don't know if this is asking too much.
Just an idea ;)

[Lars]

I like this idea! :D

[Thomas Luebking]

Not as elegant as i'd like it to be and not tested, but should work.

If you got eg.

[Trojita]
Type=Button

inside

[LaunchBar]
Type=TaskBar

inside

[BottomPanel]

Theme/Current/BottomPanel/LaunchBar/Trojita/trojita.png
would take precendece over
Theme/Current/BottomPanel/LaunchBar/trojita.png
over
Theme/Current/BottomPanel/trojita.png
over
Theme/Current/trojita.png

[Hombremaledicto]

Oh :-)

Many thanks !!!
Long time being waiting for this.

Also the merryXmas effect and the new calendar are nice. Thanks! :-)

[Hombremaledicto]

Ok: it's been a while since the last post, but this never worked.

E.g.

[kate]
Exec=kate
Icon=kate
Mode=0
Type=Button

[tasks]
Buttons=..,kate,..
Type=Taskbar

[WunderBar]
Applets=..,tasks,..
Id=WunderBar

[BE::Shell]
Panels=WunderBar,..
Theme=MyTheme

If i put a kate.png in ~/.kde4/share/apps/be.shell/Themes/MyTheme it works.
While instead, if i put it in ~/.kde4/share/apps/be.shell/Themes/MyTheme/WunderBar/tasks/ or ~/.kde4/share/apps/be.shell/Themes/MyTheme/Wunderbar etc... It does not.

Also tried with some other applets (most probably you implemented this only for buttons, for what i understood) like icons for systray or volume (creating the appropriate subdirs everytime), with no luck.

Can you fix this?

[Thomas Luebking]

Please Try:

diff --git a/button.cpp b/button.cpp
index f282b7a..03fc6e3 100644
--- a/button.cpp
+++ b/button.cpp
@@ -164,7 +164,7 @@ BE::Button::configure( KConfigGroup *grp )
         connect( this, SIGNAL(clicked()), this, SLOT(runCommand()) );

     if (!myIcon.isEmpty())
-        setIcon(themeIcon(myIcon));
+        setIcon(themeIcon(myIcon, this));
     setShortcut(QKeySequence()); // getrid of mnemonics
 }

@@ -356,7 +356,7 @@ void
 BE::Button::themeChanged()
 {
     if (!myIcon.isEmpty())
-        setIcon(themeIcon(myIcon));
+        setIcon(themeIcon(myIcon, this));
 }

 void

[Hombremaledicto]

Changed button.cpp, recompiled, restarted be.shell, yet nothing following the same from above:

~/.kde4/share/apps/be.shell/Themes/MyTheme/WunderBar/kate.png

[Thomas Luebking]

Sorry, I'm just stupid.
commit 421e2d2328e49d8e3fbf9b1104c0efcfe63272d3

[Hombremaledicto]

No problem, now it's working :)
Many thanks!