[Bcrypt-users] bcrypt-1.1 bug report

[David B. <dc...@ho...>]

Hello there,

bcrypt.spec.out:[rwfile.c:120]: (style) Variable 'state' is allocated memory that is never used.

Source code is

    if ((state = malloc(257)) == NULL)
      memerror();

    initstate((unsigned long) key, state, 256);

but

#define initstate(x,y,z) srand(x)

Suggest remove unused allocation.

There are a couple of other problems in the same file

rwfile.c:147]: (error) Memory leak: garbage
rwfile.c:147]: (error) Memory leak: state


Regards

David Binderman