#15 sctl-0.2.3 doesn't check for SG bc245 compat

[Roger]

sctl-0.2.3 doesn't check for SG bc245 compatability.

$ sctl idreport
ID report mode enabled

04/06 20:46:24 end ID: 000002
*** Error: The command failed because an error
condition was returned.
Command: SG
Reply: ERR

This command is not support for the bc245 scanners (as
well as radio shacks PRO-2052).

Insert if/then or elseif code to check for these models
should surfice.

[Roger]

Logged In: YES
user_id=348797

Here's a quick patch to check for model compatability before
issueing the SG command.

I'm not sure if it works yet as I'm not in a trunked area to
test the "sctl idreport" command.

If you're using a BC245* or PRO-2052 model, and "sctl
idreport" reports no errors, then it works.

(I'll be able to test this myself in the next day or so.)

[Roger]

Logged In: YES
user_id=348797

(I'm seeing no changes to this bug, so I'll reissue a
proposed patch to fix this bug.)

If you're using either a BC245* or PRO-2052, the "sctl
idreport" command should work without error now. I'm not in
a trunked area and cannot test for another day or so.

[Roger]

Logged In: YES
user_id=348797

Wow! That's a five minute delay until post!

[Roger]

Logged In: YES
user_id=348797

I've debugged some of this patch and it prevents sctl from
exiting abnormally by providing a check in two spots within
commands.c.

I get the following output now on an edacs system:

$ ./sctl idreport
ID report mode enabled

04/09 13:44:09 end ID: 000002
04/09 13:44:30 start ID: 000002 Freq: 0.0000 S:
04/09 13:44:38 end ID: 000002
04/09 13:44:39 start ID: 000002 Freq: 0.0000 S:
04/09 13:44:42 end ID: 000002
04/09 13:44:43 start ID: 000002 Freq: 0.0000 S:
04/09 13:44:44 end ID: 000002
04/09 13:44:45 start ID: 000002 Freq: 0.0000 S:
04/09 13:44:52 end ID: 000002
04/09 13:44:53 start ID: 000002 Freq: 0.0000 S:
04/09 13:44:53 end ID: 000002
04/09 13:44:54 start ID: 000002 Freq: 0.0000 S:
04/09 13:44:56 end ID: 000002
ID report mode disabled

The frequency is not being reported (nor is the id being
fully reported either). The reason the frequency is not
being reported is because it used to be reported by the SG
command with other units using this command. I need to
implement the command used with the bc245 to return the
frequency.

[Roger]

Logged In: YES
user_id=348797

Ok. This bug is fixed and closed with my bc245xlt scanner.

Thanks to most of the code already being written in
human_commands.c

I've implemented a check to exclude the bc245xlt and pro2052
scanners from getting the SG command and then using the WI
command to report the frequency data.

This bug appeared in both the idreport and sreport functions
of commands.c

Here's my output now with sreport and idreport:

$ ./sctl sreport d
Set radio to scan banks D.
Scanning banks D
04/09 14:29:47 end
04/09 14:29:47 start Freq: 868.7125 S: 101
04/09 14:29:55 end
04/09 14:29:55 start Freq: 866.2625 S: 100
04/09 14:29:56 end
04/09 14:29:56 start Freq: 867.2125 S: 102
04/09 14:29:57 end
04/09 14:29:58 start Freq: 867.7125 S: 099
04/09 14:29:59 end
04/09 14:29:59 start Freq: 868.2125 S: 100
ID report mode disabled

Scan report mode disabled

$ ./sctl idreport
ID report mode enabled

04/09 14:27:19 end ID: 000004
04/09 14:27:20 start ID: 000004 Freq: 867.2125 S: 096
04/09 14:27:21 end ID: 000004
04/09 14:27:22 start ID: 000004 Freq: 867.2125 S: 097
04/09 14:27:24 end ID: 000004
04/09 14:27:24 start ID: 000004 Freq: 868.2125 S: 099
04/09 14:27:24 end ID: 000004
04/09 14:27:26 start ID: 000002 Freq: 868.2625 S: 097
04/09 14:27:27 end ID: 000002
04/09 14:27:29 start ID: 000002 Freq: 868.7125 S: 098
04/09 14:27:31 end ID: 000002
04/09 14:27:32 start ID: 000002 Freq: 866.2625 S: 102
04/09 14:27:33 end ID: 000002
04/09 14:27:33 start ID: 000004 Freq: 866.7625 S: 097
04/09 14:27:34 end ID: 000004
04/09 14:27:34 start ID: 000004 Freq: 866.7125 S: 098
ID report mode disabled

Scan report mode disabled

[Roger]

SG check of bc245 compatability