#1 bbapm doesnt compile

[Anonymous]

so i run slackware 9.1 and couldnt compile bbapm

dave@laptop:~> gcc --version
gcc (GCC) 3.2.3
etc...

so there were two problems... the first was simple, i
was able to fix myself:
--- LinkedList.hh.orig Fri Sep 6 20:14:52 2002
+++ LinkedList.hh Fri Sep 6 20:14:58 2002
@@ -63,7 +63,7 @@
int elements;
__llist_node *_first, *_last;

- friend __llist_iterator;
+ friend class __llist_iterator;

protected:

the second i robbed from the freebsd patch in ports.
applying the patch for Image.cc fixed a bunch of
compile errors. i'll attach the patch which probably
everybody has seen.

anyway, even though the patch is from freebsd it seems
to be required for recent versions of gcc and linux.

[David Slorah]

Logged In: YES
user_id=956429

hmm, curious - that didnt attach. anyway i looked at the
freebsd diff posted here and it's different from what is in
ports. i also dont see a way to attach files after posting
a bug. whatever - here is the patch. sucks that it will
wrap the lines though

--- Image.cc.orig Sun Aug 15 07:43:55 1999
+++ Image.cc Mon May 19 12:56:41 2003
@@ -50,6 +50,17 @@
BImage::BImage(BImageControl *c, unsigned int w, unsigned
int h) {
control = c;

+ colors = NULL;
+ red = NULL;
+ green = NULL;
+ blue = NULL;
+ tr = NULL;
+ tg = NULL;
+ tb = NULL;
+
+ from.allocated = 0;
+ to.allocated = 0;
+
width = ((signed) w > 0) ? w : 1;
height = ((signed) h > 0) ? h : 1;

@@ -225,12 +236,12 @@
}

if (control->doDither()) {
- short er, eg, eb, *or, *og, *ob, *nor, *nog, *nob,
*por, *pog, *pob;
+ short er, eg, eb, *bbor, *og, *ob, *nor, *nog, *nob,
*por, *pog, *pob;
unsigned short *ort, *ogt, *obt;

- control->getDitherBuffers(width + 2, &or, &og, &ob,
&nor, &nog, &nob,
+ control->getDitherBuffers(width + 2, &bbor, &og, &ob,
&nor, &nog, &nob,
&ort, &ogt, &obt);
- if ((! or) || (! og) || (! ob) || (! nor) || (! nog) ||
(! nob) ||
+ if ((! bbor) || (! og) || (! ob) || (! nor) || (! nog)
|| (! nob) ||
(! ort) || (! ogt) || (! obt)) {
fprintf(stderr,
"BImage::renderXImage: error getting dither
information\n");
@@ -240,7 +251,7 @@

 x = width;

- por = or;
+ por = bbor;
pog = og;
pob = ob;

@@ -271,14 +282,14 @@

if (control->doDither()) {
- short er, eg, eb, *or, *og, *ob, *nor, *nog, *nob,
*por, *pog, *pob;
+ short er, eg, eb, *bbor, *og, *ob, *nor, *nog, *nob,
*por, *pog, *pob;
unsigned short *ort, *ogt, *obt;

- control->getDitherBuffers(width + 2, &or, &og, &ob,
&nor, &nog, &nob,
+ control->getDitherBuffers(width + 2, &bbor, &og, &ob,
&nor, &nog, &nob,
&ort, &ogt, &obt);
- if ((! or) || (! og) || (! ob) || (! nor) || (! nog) ||
(! nob) ||
+ if ((! bbor) || (! og) || (! ob) || (! nor) || (! nog)
|| (! nob) ||
(! ort) || (! ogt) || (! obt)) {
fprintf(stderr,
"BImage::renderXImage: error getting dither
information\n");
@@ -240,7 +251,7 @@

 x = width;

- por = or;
+ por = bbor;
pog = og;
pob = ob;

@@ -271,14 +282,14 @@
}

   for \(x = 0; x < width; x++\) \{

- if (*(or + x) > 255) *(or + x) = 255;
- else if (*(or + x) < 0) *(or + x) = 0;
+ if (*(bbor + x) > 255) *(bbor + x) = 255;
+ else if (*(bbor + x) < 0) *(bbor + x) = 0;
if (*(og + x) > 255) *(og + x) = 255;
else if (*(og + x) < 0) *(og + x) = 0;
if (*(ob + x) > 255) *(ob + x) = 255;
else if (*(ob + x) < 0) *(ob + x) = 0;

- r = *(tr + *(or + x));
+ r = *(tr + *(bbor + x));
g = *(tg + *(og + x));
b = *(tb + *(ob + x));

@@ -340,11 +351,11 @@
return 0;
}

- er = *(or + x) - *(ort + *(or + x));
+ er = *(bbor + x) - *(ort + *(bbor + x));
eg = *(og + x) - *(ogt + *(og + x));
eb = *(ob + x) - *(obt + *(ob + x));

- *(or + x + 1) += er;
+ *(bbor + x + 1) += er;
*(og + x + 1) += eg;
*(ob + x + 1) += eb;

@@ -360,7 +371,7 @@
off += image->width;
idata = (pd += image->bytes_per_line);

- por = or; or = nor; nor = por;
+ por = bbor; bbor = nor; nor = por;
pog = og; og = nog; nog = pog;
pob = ob; ob = nob; nob = pob;
}
@@ -843,7 +854,14 @@
window = blackbox->getRootWindow();
screen_number = blackbox->getScreenNumber();

- colors = 0;
+ colors = NULL;
+ red_err = NULL;
+ green_err = NULL;
+ blue_err = NULL;
+ next_red_err = NULL;
+ next_green_err = NULL;
+ next_blue_err = NULL;
+ cache = NULL;
colors_per_channel = ncolors = 0;

int count;