Menu

#21 attachment slowdown fix

open
nobody
None
5
2004-09-13
2004-09-13
Anonymous
No

In one of the earlier emails from the basilix user
group on yahoo, D. Clarke fixed an attachment problem
that was not incorporated in any of these fixes. Here
it is:

I found the offending function that was causing
extended attachment
processing time.

in /usr/local/basillix/lib/compose.inc change the
function prepare_data($d)
to...

function prepare_data($d) {
// $nd = ereg_replace("\r", "", $d);
// $nd = ereg_replace("\n", "\r\n", $nd);
$nd = str_replace("\r","",$d);
$nd = str_replace("\n","\r\n",$nd);
return $nd;
}

ereg_replace takes up WAY too much juice, especially
for what it's used for
in this instance. str_replace is much much much faster
(as you will see).

Please add this modification to the new versions.

Thanks!

Discussion


Log in to post a comment.