From: Josh J. <jj...@gm...> - 2012-08-10 17:15:10
|
On Aug 8, 2012, at 9:15 PM, Alexei Svitkine wrote: > I am not convinced that the revision in question is the cause of the > issue you're seeing. > > I've read over that change and it seems correct to me. Perhaps > something else is going wrong that is corrupting the internal state of > those linked lists and that change merely exposes the issue? You may be right. While reverting the patch avoids the garbled error I was seeing, I still get occasional SheepShaver crashes. I haven't reviewed all the changes between Git 1.7.5.4 and 1.7.6, but one file, sha1-array.c, was added, and a broken SHA1 hash is consistent with the error I was getting from Git. > Could you actually debug this and verify that the two paths in that > function end up invalidating different nodes? I don't have time for this right now, but I intend to pursue it later. Josh |