From: Robert M. <mr...@gm...> - 2012-07-01 05:42:51
|
Oh, that explains why I didn't see a problem: I created the eject fix and sent it to the list, and when it was committed to the CVS, I didn't do a CVS update because I already have the bug fix. Therefore, I didn't get the "Fix inverted check from..." change. I do remember noting that they had decided to fix the eject problem in a different way than I had suggested, but was too busy to test their version. (Although it wouldn't have done any good, because I would have only been testing for proper ejecting when nocdron is true, as opposed to proper mounting when nocdrom is false...) On Saturday, June 30, 2012, Ronald P. Regensburg wrote: > It took me a while to get (somewhat) familiar with the new GitHub > repository. But I found where the problem with CD-ROMs not mounting in > SheepShaver MacOSX started. > > It started April 21, 2012 with commit > 6ee2964818c58fd6d7c512d9f61d2a9d343ebf20 > "Fix inverted check from my previous commit." > > The commit immediately before that: > 2b348f7c4158022d8747ba7fe22c93197d6a059b > "Don't start the Darwin media_thread if "nocdrom" pref is set." > Mounts CD-ROMs alright. > > Not sure, but I suppose the "fix" was made by mistake because of the > description > "Don't start the Darwin media_thread if "nocdrom" pref is set." > It could better have been described: > Start the Darwin media_thread only if "nocdrom" pref is not set.l<https://lists.sourceforge.net/lists/listinfo/basilisk-devel> > -- Robert Munafo -- mrob.com Follow me at: gplus.to/mrob - fb.com/mrob27 - twitter.com/mrob_27 - mrob27.wordpress.com - youtube.com/user/mrob143 - rilybot.blogspot.com |